`no-unused-disable` is redundant

[CruseCtrl]

Eslint already has the reportUnusedDisableDirectives setting, and starting in eslint v9, that setting is enabled by default: https://eslint.org/docs/latest/use/configure/rules#report-unused-eslint-disable-comments

It also has auto-fix, so running eslint --fix will automatically remove any unused disable directives. I don't think the no-unused-disable is adding anything extra, so it should be removed from this plugin

[SamuelT-Beslogic]

Idk if that still true, but in #234 (comment) I mentioned that the ESLint option "Doesn't seem to be picked up by extending configurations".
But even if it is now:

There's one use-case where it's still not fully redundant: Flagging without autofixes. Which is especially sensical with this rules as you may not want a "disable removal" to slip through unnoticed due to a bad configuration change.

• @eslint-community/eslint-comments/no-unused-disable option to disable autofix #234

Using the https://www.npmjs.com/package/eslint-plugin-no-autofix plugin:

'@eslint-community/eslint-comments/no-unused-disable': 'off',
'no-autofix/@eslint-community/eslint-comments/no-unused-disable': 'error',

In VSCode settings:

"eslint.codeActionsOnSave.rules": [
  // Clearing imports, unused vars and comments because of commented code while testing is annoying
  ...
  "!@eslint-community/eslint-comments/no-unused-disable",
  "*"
],

There is a RFC to obsolete eslint-plugin-no-autofix and include the functionality in base ESLint, but I need help completing that

• Change Request: Ability to disable autofixes on a per-rule basis eslint/eslint#18696
• https://github.com/eslint/rfcs/pull/125/files#diff-29496ca2df74fbb42d2b5a6e455e7f5a10fbb3e63a8b7a0edc8f83c089bc0019

The RFC currently doesn't even mention linterOptions.reportUnusedDisableDirectives as I just learned about it. I'll have to add it.

However, this rule is currently broken on flat-configs anyway, unfortunately

• no-unused-disable does not work when turned on in a flat config #244

[CruseCtrl]

@Samuel-Therrien-Beslogic I don't think we should be striving to keep redundant functionality in this plugin just because a different unrelated plugin provides complementary functionality.

If you want a option to flag unused disable directives then I think that would be something to discuss with the main eslint team (or make your own plugin), but tbh I'm struggling to see what the point is. You can already use eslint without the --fix parameter if you don't want to apply autofixes, and if you did accidentally make a bad config change that removed a disable comment then it would be obvious in code review, and in that case it sounds like the config change would be at fault rather than anything to do with reportUnusedDisableDirectives

[cylewaitforit]

I think it is at least worth updating the documentation for the rule to call out reportUnusedDisableDirectives could be used to achieve a similar effect and what the upsides, if any, of using the rule instead.