Package ships with TS types that refers to `@eslint/core`

[SimenB]

7.1.0 and 7.2.0 refers to @eslint/core which is not a declared dependency: https://www.runpkg.com/?eslint-plugin-eslint-plugin@7.2.0/dist/index.d.ts#1

7.0.0 does not have this issue: https://www.runpkg.com/?eslint-plugin-eslint-plugin@7.0.0/dist/index.d.ts#1

I don't know what changed that makes tsc refer to that package when it's eslint in the source 🤔

---

This gives type errors in repos without skipLibCheck: true

[michaelfaith]

I suspect it's this change in eslint https://github.com/eslint/eslint/pull/20168/files. So, this repo doesn't use a lock file. And, as a result, in pipeline runs it's just pulling in whatever version of packages satisfies the range. So, even though 7.0.0 - 7.2.0 all declared the same version of eslint in devDependencies (^9.31.0), at the time the package was built for each version, it was using whatever the latest version of eslint was at the time. So, nothing really changed on our side, but we were using a different version of eslint (and its types) to build with. This could make a good argument to pin the devDependencies in the package.json to avoid that kind of variability (or adopt a lock file)?

But, the net, net is that this appears to be the result of an upstream change.

[SimenB]

Ah, I just noticed the minimum version of eslint here is v9. We're on v8, which doesn't pull in @eslint/core. That explains the error 😀