Do we have a specific reason for marking assert as external? There might be cases where assert is not available in the environment where the package (scope-manager) is being used.

it's to avoid the rollup warnings: https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency. I'd suggest not using assert, but just throw an error:

if(this.__currentScope !== null) {throw new Error("an error happened.")}

This is left over from when we forked escope. I don't think there's any reason to reference the assert package.

I think the easiest thing is just to create and use our own assert function:

function assert(condition, message = "Assertion failed.") {
    if (!condition) {
        throw new Error(message);
    }
}

And then replace the references to assert package with this function.

@amareshsm do you want to take a look at this?

Sure. I will look into this.

This is left over from when we forked escope. I don't think there's any reason to reference the assert package.

I think the easiest thing is just to create and use our own assert function:

function assert(condition, message = "Assertion failed.") {
if (!condition) {
throw new Error(message);
}
}
And then replace the references to assert package with this function.

@amareshsm do you want to take a look at this?

The test files also contain references. Should we leave them as is, since they won’t be included in the bundle?

The test files also contain references. Should we leave them as is, since they won’t be included in the bundle?

Yes.