feat: Add sort-keys rule #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RobertAKARobin
force-pushed
the
feat/sort-keys
branch
2 times, most recently
from
2c210e9 to
d651aae
Compare
RobertAKARobin
commented
Jan 9, 2025
crimx
reviewed
Jan 10, 2025
nzakas
reviewed
Jan 10, 2025
|
Think I addressed all feedback. Thanks! |
RobertAKARobin
force-pushed
the
feat/sort-keys
branch
from
7d9916f to
69211e8
Compare
RobertAKARobin
force-pushed
the
feat/sort-keys
branch
from
0e6aac4 to
337dd83
Compare
nzakas
previously approved these changes
Jan 15, 2025
nzakas
previously approved these changes
Jan 16, 2025
Co-authored-by: Nicholas C. Zakas <[email protected]>
Co-authored-by: Nicholas C. Zakas <[email protected]>
RobertAKARobin
force-pushed
the
feat/sort-keys
branch
from
53b4cda to
933539a
Compare
RobertAKARobin
force-pushed
the
feat/sort-keys
branch
from
7cfda22 to
708311c
Compare
tests/rules/sort-keys.test.js
Outdated
| `, | ||
| language: "json/jsonc", | ||
| options: ["asc", { allowLineSeparatedGroups: true }], | ||
| languageOptions: { ecmaVersion: 6 }, |
There was a problem hiding this comment.
Suggested change
| languageOptions: { ecmaVersion: 6 }, |
There was a problem hiding this comment.
Updated 765cbde That was left over from copying from eslint/sort-keys
tests/rules/sort-keys.test.js
Outdated
| `, | ||
| language: "json/jsonc", | ||
| options: ["asc", { allowLineSeparatedGroups: true }], | ||
| languageOptions: { ecmaVersion: 6 }, |
There was a problem hiding this comment.
Suggested change
| languageOptions: { ecmaVersion: 6 }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Adds a
sort-keysrule for JSON that mimics the functionality of the existingsort-keysfor JS.What changes did you make? (Give an overview)
Added a
sort-keysrule and tests.Related Issues
Fixes #75
Is there anything you'd like reviewers to focus on?
I started by copying over the existing code for JS
sort-keys, but it required some big modifications in order to work on JSON. It would be nice if there was an automated way to make sure thissort-keysmaintains parity with thatsort-keysto keep things consistent across ESLint packages, but JS and JSON are different enough that I'm not sure how it could be done.json/tests/rules/sort-keys.test.js
Line 2 in 7fe2782
Note that I added a TODO for how comments affect line-separated groups