Refactor application type handling in configuration

- Updated the application type references in `main.py` and `validation.py` to use the `ApplicationType` enum for improved clarity and consistency.
- Changed the `NULL` value to `NONE` in the `ApplicationType` enum to better reflect its purpose.
- Adjusted related logic in the `NullApplicationConfig` and validation methods to align with the updated enum values.

Author: tansdf

app/config/validation.py

@@ -16,7 +16,7 @@ class ApplicationType(str, Enum):
     SLACK = "slack"
     MATTERMOST = "mattermost"
     TELEGRAM = "telegram"
-    NULL = "none"
+    NONE = "none"
 
 
 class ChainType(str, Enum):
@@ -284,7 +284,7 @@ class TelegramApplicationConfig(BaseApplicationConfig):
 
 class NullApplicationConfig(BaseApplicationConfig):
     """Null application configuration for UI-only mode"""
-    type: Literal[ApplicationType.NULL] = Field(ApplicationType.NULL, description="Application type")
+    type: Literal[ApplicationType.NONE] = Field(ApplicationType.NONE, description="Application type")
     channels: Optional[Dict[str, Any]] = Field(default_factory=dict, description="Channel definitions (not used)")
     users: Optional[Dict[str, Any]] = Field(default_factory=dict, description="User definitions (not used)")
     admin_users: List[str] = Field(default_factory=list, description="Admin users (not used)")
@@ -452,7 +452,7 @@ def validate_route_channel_exists(self):
         """Validate that route channels exist in application channels"""
 
         def validate_route_channels(route_config):
-            if route_config.channel not in self.application.channels and self.application.type != ApplicationType.NULL:
+            if route_config.channel not in self.application.channels and self.application.type != ApplicationType.NONE:
                 raise ValueError(f"Route channel '{route_config.channel}' not found in application channels")
 
             if route_config.routes:

main.py

@@ -11,6 +11,7 @@
 from fastapi.staticfiles import StaticFiles
 from fastapi.templating import Jinja2Templates
 
+from app.config.validation import ApplicationType
 from app.im.channel_manager import ChannelManager
 from app.im.helpers import get_application
 from app.incident.incidents import Incidents
@@ -80,7 +81,7 @@ async def lifespan(fastapi_app: FastAPI):
     route = generate_route(route_dict)
 
     channel_manager = ChannelManager()
-    if config.application.type == 'none':
+    if config.application.type == ApplicationType.NONE:
         if not config.application.channels or 'default' not in config.application.channels:
             config.application.channels = {'default': {'id': 'default'}}
         channels = channel_manager.initialize(['default'], config.application.channels, 'default')