Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support build parameters #58

Open
spuder opened this issue Nov 3, 2024 · 1 comment
Open

[Feature] Support build parameters #58

spuder opened this issue Nov 3, 2024 · 1 comment

Comments

@spuder
Copy link

spuder commented Nov 3, 2024

As a user who builds esphome using build parameters.
I need the ability to provide those build parameters to the GitHub actions.

Example

Production boards are built using different pin assignments than the development boards.

	esphome \
		-s name foobar \
		-s rfid1_miso_pin "GPIO37" \
		-s rfid1_clk_pin "GPIO36" \
		-s rfid1_mosi_pin "GPIO35" \
		-s rfid1_ss_pin "GPIO34" \
		-s rfid1_spi_interface "spi2" \
		compile config.yaml

Desired outcome

      - name: Build ESPHome firmware
        uses: esphome/[email protected]
        with:
          yaml-file: firmware/config.yaml
          complete-manifest: true
          build_parameters: # <------- add build parameters
            - name: foobar
            - rfid1_miso_pin: GPIO37
            - rfid1_clk_pin: GPIO36
            - rfid1_mosi_pin: GPIO35
            - rfid1_ss_pin: GPIO34
@spuder
Copy link
Author

spuder commented Nov 3, 2024

Additional use case example

substitutions:
  version: "0.1.0"

esphome:
  name: living_room_sensor
  min_version: "2023.11.0"
  project:
    name: "your_name.living_room_project"
    version: ${version}

Where $version is provided automatically on a git tag or release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant