fix(lcd): Fixed some known issues with LCD components

Horion0415 · Horion0415 · commit 36b51de1f42d · 2025-04-07T18:01:34.000+08:00
diff --git a/.gitignore b/.gitignore
@@ -19,6 +19,9 @@ GPATH
 # eclipse setting
 .settings
 
+# clangd cache directory files
+.cache
+
 # MacOS directory files
 .DS_Store
 
diff --git a/.gitlab/ci/build.yml b/.gitlab/ci/build.yml
@@ -441,7 +441,7 @@ build_example_display_lcd_rgb_lcd_8bit:
     - .rules:build:example_display_lcd_rgb_lcd_8bit
   parallel:
     matrix:
-      - IMAGE: espressif/idf:release-v5.1
+      - IMAGE: espressif/idf:release-v5.3
   variables:
     EXAMPLE_DIR: examples/display/lcd/rgb_lcd_8bit
 
@@ -451,7 +451,7 @@ build_example_display_lcd_rgb_avoid_tearing:
     - .rules:build:example_display_lcd_rgb_avoid_tearing
   parallel:
     matrix:
-      - IMAGE: espressif/idf:release-v5.1
+      - IMAGE: espressif/idf:release-v5.3
   variables:
     EXAMPLE_DIR: examples/display/lcd/rgb_avoid_tearing
 
diff --git a/.gitlab/ci/deploy.yml b/.gitlab/ci/deploy.yml
@@ -110,8 +110,8 @@ pack-upload_files:
     - job: "build_example_display_lcd_lcd_with_te: [espressif/idf:release-v5.1]"
     - job: "build_example_display_lcd_qspi_with_ram: [espressif/idf:release-v5.1]"
     - job: "build_example_display_lcd_qspi_without_ram: [espressif/idf:release-v5.3]"
-    - job: "build_example_display_lcd_rgb_avoid_tearing: [espressif/idf:release-v5.1]"
-    - job: "build_example_display_lcd_rgb_lcd_8bit: [espressif/idf:release-v5.1]"
+    - job: "build_example_display_lcd_rgb_avoid_tearing: [espressif/idf:release-v5.3]"
+    - job: "build_example_display_lcd_rgb_lcd_8bit: [espressif/idf:release-v5.3]"
     - job: "build_example_keyboard: [espressif/idf:release-v5.3]"
     - job: "build_example_usb_device_bootloader_uf2: [espressif/idf:release-v5.3]"
     - job: "build_example_usb_device_usb_dongle: [espressif/idf:release-v5.3]"
diff --git a/components/display/lcd/esp_lcd_st7701/CHANGELOG.md b/components/display/lcd/esp_lcd_st7701/CHANGELOG.md
@@ -1,5 +1,11 @@
 # ChangeLog
 
+## v1.1.2 - 2025-04-03
+
+### bugfix:
+
+* Fixed the issue where the ST7701 RGB interface mirror and swap were ineffective
+
 ## v1.1.1 - 2024-11-10
 
 ### bugfix:
diff --git a/components/display/lcd/esp_lcd_st7701/esp_lcd_st7701_rgb.c b/components/display/lcd/esp_lcd_st7701/esp_lcd_st7701_rgb.c
@@ -338,9 +338,20 @@ static esp_err_t panel_st7701_mirror(esp_lcd_panel_t *panel, bool mirror_x, bool
         } else {
             st7701->madctl_val &= ~LCD_CMD_ML_BIT;
         }
+
+        // Enable the Command2 BK0
+        ESP_RETURN_ON_ERROR(esp_lcd_panel_io_tx_param(io, ST7701_CMD_CND2BKxSEL, (uint8_t []) {
+            ST7701_CMD_BKxSEL_BYTE0, ST7701_CMD_BKxSEL_BYTE1, ST7701_CMD_BKxSEL_BYTE2, ST7701_CMD_BKxSEL_BYTE3,
+                                     ST7701_CMD_BKxSEL_BK0 | ST7701_CMD_CN2_BIT,
+        }, 5), TAG, "send command failed");
         ESP_RETURN_ON_ERROR(esp_lcd_panel_io_tx_param(io, ST7701_CMD_SDIR, (uint8_t[]) {
             sdir_val,
         }, 1), TAG, "send command failed");;
+
+        // Disable Command2
+        ESP_RETURN_ON_ERROR(esp_lcd_panel_io_tx_param(io, ST7701_CMD_CND2BKxSEL, (uint8_t []) {
+            ST7701_CMD_BKxSEL_BYTE0, ST7701_CMD_BKxSEL_BYTE1, ST7701_CMD_BKxSEL_BYTE2, ST7701_CMD_BKxSEL_BYTE3, 0,
+        }, 5), TAG, "send command failed");
         ESP_RETURN_ON_ERROR(esp_lcd_panel_io_tx_param(io, LCD_CMD_MADCTL, (uint8_t[]) {
             st7701->madctl_val,
         }, 1), TAG, "send command failed");;
diff --git a/components/display/lcd/esp_lcd_st7701/idf_component.yml b/components/display/lcd/esp_lcd_st7701/idf_component.yml
@@ -1,4 +1,4 @@
-version: "1.1.1"
+version: "1.1.2"
 targets:
   - esp32s3
   - esp32p4
diff --git a/components/display/lcd/esp_lcd_st7703/CHANGELOG.md b/components/display/lcd/esp_lcd_st7703/CHANGELOG.md
@@ -1,5 +1,11 @@
 # ChangeLog
 
+## v1.0.3 - 2025-04-03
+
+### bugfix:
+
+* Added configuration for sending initialization parameters in command mode
+
 ## v1.0.2 - 2025-01-13
 
 ### bugfix:
diff --git a/components/display/lcd/esp_lcd_st7703/README.md b/components/display/lcd/esp_lcd_st7703/README.md
@@ -12,6 +12,18 @@ Implementation of the ST7703 LCD controller with esp_lcd component.
 
 For more information on LCD, please refer to the [LCD documentation](https://docs.espressif.com/projects/esp-iot-solution/en/latest/display/lcd/index.html).
 
+If the screen still fails to turn on after confirming that the initialization register parameters and timing parameters are correct, you can try enabling the `init_in_command_mode` parameter in the `st7703_vendor_config_t` configuration.
+
+```c
+
+    st7703_vendor_config_t vendor_config = {
+        ...
+        .init_in_command_mode = true,
+        ...
+    };
+
+```
+
 ## Add to project
 
 Packages from this repository are uploaded to [Espressif's component service](https://components.espressif.com/).
diff --git a/components/display/lcd/esp_lcd_st7703/esp_lcd_st7703.c b/components/display/lcd/esp_lcd_st7703/esp_lcd_st7703.c
@@ -26,6 +26,7 @@ typedef struct {
     uint8_t colmod_val; // save surrent value of LCD_CMD_COLMOD register
     const st7703_lcd_init_cmd_t *init_cmds;
     uint16_t init_cmds_size;
+    bool init_in_command_mode;
     struct {
         unsigned int reset_level: 1;
     } flags;
@@ -97,6 +98,7 @@ esp_err_t esp_lcd_new_panel_st7703(const esp_lcd_panel_io_handle_t io, const esp
     st7703->init_cmds_size = vendor_config->init_cmds_size;
     st7703->reset_gpio_num = panel_dev_config->reset_gpio_num;
     st7703->flags.reset_level = panel_dev_config->flags.reset_active_high;
+    st7703->init_in_command_mode = vendor_config->init_in_command_mode;
 
     // Create MIPI DPI panel
     esp_lcd_panel_handle_t panel_handle = NULL;
@@ -181,7 +183,9 @@ static esp_err_t panel_st7703_init(esp_lcd_panel_t *panel)
     uint16_t init_cmds_size = 0;
     bool is_cmd_overwritten = false;
 
-    ESP_RETURN_ON_ERROR(st7703->init(panel), TAG, "init MIPI DPI panel failed");
+    if (!st7703->init_in_command_mode) {
+        ESP_RETURN_ON_ERROR(st7703->init(panel), TAG, "init MIPI DPI panel failed");
+    }
 
     uint8_t ID[3];
     ESP_RETURN_ON_ERROR(esp_lcd_panel_io_rx_param(io, 0x04, ID, 3), TAG, "read ID failed");
@@ -234,6 +238,10 @@ static esp_err_t panel_st7703_init(esp_lcd_panel_t *panel)
     }
     ESP_LOGD(TAG, "send init commands success");
 
+    if (st7703->init_in_command_mode) {
+        ESP_RETURN_ON_ERROR(st7703->init(panel), TAG, "init MIPI DPI panel failed");
+    }
+
     return ESP_OK;
 }
 
diff --git a/components/display/lcd/esp_lcd_st7703/idf_component.yml b/components/display/lcd/esp_lcd_st7703/idf_component.yml
@@ -1,4 +1,4 @@
-version: "1.0.2"
+version: "1.0.3"
 targets:
   - esp32p4
 description: ESP LCD ST7703(MIPI-DSI)
diff --git a/components/display/lcd/esp_lcd_st7703/include/esp_lcd_st7703.h b/components/display/lcd/esp_lcd_st7703/include/esp_lcd_st7703.h
@@ -40,6 +40,7 @@ typedef struct {
                                                      *   Please refer to `vendor_specific_init_default` in source file.
                                                      */
     uint16_t init_cmds_size;                        /*<! Number of commands in above array */
+    bool init_in_command_mode;                      /*!< Send LCD initialization commands in command-mode, default in video-mode */
     struct {
         esp_lcd_dsi_bus_handle_t dsi_bus;               /*!< MIPI-DSI bus configuration */
         const esp_lcd_dpi_panel_config_t *dpi_config;   /*!< MIPI-DPI panel configuration */
diff --git a/components/display/lcd/esp_lcd_st77922/test_apps/sdkconfig.defaults.esp32s3 b/components/display/lcd/esp_lcd_st77922/test_apps/sdkconfig.defaults.esp32s3
@@ -1,7 +1,8 @@
+CONFIG_ESPTOOLPY_FLASHFREQ_80M=y
+CONFIG_COMPILER_OPTIMIZATION_PERF=y
 CONFIG_SPIRAM=y
 CONFIG_SPIRAM_MODE_OCT=y
 CONFIG_SPIRAM_FETCH_INSTRUCTIONS=y
 CONFIG_SPIRAM_RODATA=y
 CONFIG_SPIRAM_SPEED_80M=y
 CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
-CONFIG_ESP32S3_DATA_CACHE_LINE_64B=y
diff --git a/examples/display/lcd/mipi_dsi_avoid_tearing/main/idf_component.yml b/examples/display/lcd/mipi_dsi_avoid_tearing/main/idf_component.yml
@@ -1,6 +1,6 @@
 dependencies:
   idf:
-    version: ">=5.1.0"
+    version: ">=5.3.0"
 
   lvgl/lvgl:
     version: "^9"
diff --git a/examples/display/lcd/rgb_avoid_tearing/main/idf_component.yml b/examples/display/lcd/rgb_avoid_tearing/main/idf_component.yml
@@ -1,6 +1,6 @@
 dependencies:
   idf:
-    version: ">=5.1.0"
+    version: ">=5.3.0"
 
   lvgl/lvgl:
     version: ">8.3.9,<9"
diff --git a/examples/display/lcd/rgb_avoid_tearing/main/lvgl_port_v8.c b/examples/display/lcd/rgb_avoid_tearing/main/lvgl_port_v8.c
@@ -595,6 +595,7 @@ esp_err_t lvgl_port_init(esp_lcd_panel_handle_t lcd_handle, esp_lcd_touch_handle
     ESP_ERROR_CHECK(tick_init());
 
     lvgl_port_interface = interface;
+#if LVGL_PORT_AVOID_TEAR_ENABLE
     switch (interface) {
 #if SOC_LCDCAM_RGB_LCD_SUPPORTED
     case LVGL_PORT_INTERFACE_RGB:
@@ -613,6 +614,7 @@ esp_err_t lvgl_port_init(esp_lcd_panel_handle_t lcd_handle, esp_lcd_touch_handle
         ESP_LOGE(TAG, "Invalid interface type");
         return ESP_ERR_INVALID_ARG;
     }
+#endif
 
     lv_disp_t *disp = display_init(lcd_handle);
     assert(disp);
diff --git a/examples/display/lcd/rgb_lcd_8bit/main/idf_component.yml b/examples/display/lcd/rgb_lcd_8bit/main/idf_component.yml
@@ -1,6 +1,6 @@
 dependencies:
   idf:
-    version: ">=5.1.0"
+    version: ">=5.3.0"
 
   lvgl/lvgl:
     version: "^9"

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-version: "1.1.1"`
	`1`	`+version: "1.1.2"`
`2`	`2`	`targets:`
`3`	`3`	`- esp32s3`
`4`	`4`	`- esp32p4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-version: "1.0.2"`
	`1`	`+version: "1.0.3"`
`2`	`2`	`targets:`
`3`	`3`	`- esp32p4`
`4`	`4`	`description: ESP LCD ST7703(MIPI-DSI)`