fix(esp_schedule): Using timestamp_cb pulled from NVS could cause crash#744
Merged
Merged
Conversation
Collaborator
Author
|
Hi @Junius00 , please take a look. |
omnitex
approved these changes
May 7, 2026
Junius00
approved these changes
May 7, 2026
Contributor
Junius00
left a comment
Junius00
left a comment
There was a problem hiding this comment.
LGTM, please bump the version patch number
Test Results40 files 40 suites 1m 44s ⏱️ Results for commit 64c953e. |
…sh on reboot due to potential function address change during recompilation Closes #734
adokitkat
force-pushed
the
fix/esp_schedule_nvs_timestamp_cb_crash
branch
from
64c953e to
4a19d11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using timestamp_cb pulled from NVS could cause crash on reboot due to potential function address change during recompilation.
Closes #734
Checklist
Change description
Added
schedule->timestamp_cb = NULL;toesp_schedule_initfuntion.