Merge pull request #3825 from thyttan/widmsggrid

bobrippling · web-flow · commit a6e622c40fb6 · 2025-04-25T08:41:25.000+01:00
widmsggrid: reset graphics state after setClipRect
diff --git a/apps/widmsggrid/ChangeLog b/apps/widmsggrid/ChangeLog
@@ -4,3 +4,4 @@
 0.04: Remove library stub
 0.05: Don't turn on LCD
 0.06: Don't draw outside of widget field
+0.07: Don't leave clipRect modified, as per [this comment](https://github.com/espruino/BangleApps/pull/3813#issuecomment-2826952155).
diff --git a/apps/widmsggrid/metadata.json b/apps/widmsggrid/metadata.json
@@ -1,7 +1,7 @@
 {
   "id": "widmsggrid",
   "name": "Messages Grid Widget",
-  "version": "0.06",
+  "version": "0.07",
   "description": "Widget that displays notification icons in a grid",
   "icon": "widget.png",
   "type": "widget",
diff --git a/apps/widmsggrid/widget.js b/apps/widmsggrid/widget.js
@@ -49,6 +49,7 @@
           r++;
         }
       });
+      g.reset(); // Make sure we don't leave clipRect set to some smaller rectangle.
       if (w.total > 1) {
         // show total number of messages in bottom-right corner
         g.reset();

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"id": "widmsggrid",`
`3`	`3`	`"name": "Messages Grid Widget",`
`4`		`- "version": "0.06",`
	`4`	`+ "version": "0.07",`
`5`	`5`	`"description": "Widget that displays notification icons in a grid",`
`6`	`6`	`"icon": "widget.png",`
`7`	`7`	`"type": "widget",`
Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@`
`49`	`49`	`r++;`
`50`	`50`	`}`
`51`	`51`	`});`
	`52`	`+ g.reset(); // Make sure we don't leave clipRect set to some smaller rectangle.`
`52`	`53`	`if (w.total > 1) {`
`53`	`54`	`// show total number of messages in bottom-right corner`
`54`	`55`	`g.reset();`