[Power Manager] Stable percentage makes battery report a wrong constant percent value

[RelapsingCertainly]

Affected hardware version

Bangle 2

Your firmware version

2v27

The bug

Described bug:
if stable percentage is enabled, then regardless of the charging status, the battery percentage will not report any other value apart from the inital value. This results in the same battery percentage being shown until the watch is hard reloaded or the bangle shuts down.

Expected Behaviour:
Stable percentage should make it so during discharge, if the battery percent goes down, it reports that as the new percent; however, if the percent is reported to be higher than the current saved value, it is ignored resulting in the battery percentage on going down unless charging. In which case, battery percentage should only go up.

Steps:

1. Install Power Manager 0.12
2. Enable stable percentage
3. Put bangle on charge or leave to discharge for.
4. The percentage will not go up or down until the bangle presumibly dies

Installed apps

boot (0.66), setting (0.81), launch (0.25), sched (0.33), clock_info (0.19), modclock (0.04), powermanager (0.12), multitimer (0.11), messageicons (0.09), reply (0.03), messagegui (0.88), widmessages (0.07), messages (0.67), android (0.44), authentiwatch (0.07), notify (0.14), health (0.37), kbmulti (0.09), sleeplog (0.20), backlite (0.02), smartbatt (0.01), mylocation (0.11), clkinfosunrise (0.05)

[RKBoss6]

Just made a PR to fix this, #3958 thanks for the notice :)

[RelapsingCertainly]

Issue has been fixed with Pull #3958