chore(packages/tests): update bal mappers (#1661)

* chore(packages/tests): update bal mappers

* chore(test-tools): ruff format / fix lint

---------

Co-authored-by: fselmo <[email protected]>

Author: spencer-tb

packages/testing/src/execution_testing/client_clis/clis/besu.py

@@ -296,26 +296,6 @@ class BesuExceptionMapper(ExceptionMapper):
         BlockException.RLP_BLOCK_LIMIT_EXCEEDED: (
             r"Block size of \d+ bytes exceeds limit of \d+ bytes"
         ),
-        BlockException.INVALID_BAL_EXTRA_ACCOUNT: (
-            r"Block access list hash mismatch, "
-            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
-        ),
-        BlockException.INVALID_BAL_HASH: (
-            r"Block access list hash mismatch, "
-            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
-        ),
-        BlockException.INVALID_BAL_MISSING_ACCOUNT: (
-            r"Block access list hash mismatch, "
-            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
-        ),
-        BlockException.INVALID_BLOCK_ACCESS_LIST: (
-            r"Block access list hash mismatch, "
-            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
-        ),
-        BlockException.INCORRECT_BLOCK_FORMAT: (
-            r"Block access list hash mismatch, "
-            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
-        ),
         TransactionException.INITCODE_SIZE_EXCEEDED: (
             r"transaction invalid Initcode size of \d+ exceeds maximum size of \d+"
         ),
@@ -345,4 +325,25 @@ class BesuExceptionMapper(ExceptionMapper):
         TransactionException.TYPE_3_TX_BLOB_COUNT_EXCEEDED: (
             r"Blob transaction has too many blobs: \d+|Invalid Blob Count: \d+"
         ),
+        # BAL Exceptions: TODO - review once all clients completed.
+        BlockException.INVALID_BAL_EXTRA_ACCOUNT: (
+            r"Block access list hash mismatch, "
+            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
+        ),
+        BlockException.INVALID_BAL_HASH: (
+            r"Block access list hash mismatch, "
+            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
+        ),
+        BlockException.INVALID_BAL_MISSING_ACCOUNT: (
+            r"Block access list hash mismatch, "
+            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
+        ),
+        BlockException.INVALID_BLOCK_ACCESS_LIST: (
+            r"Block access list hash mismatch, "
+            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
+        ),
+        BlockException.INCORRECT_BLOCK_FORMAT: (
+            r"Block access list hash mismatch, "
+            r"calculated:\s*(0x[a-f0-9]+)\s+header:\s*(0x[a-f0-9]+)"
+        ),
     }

packages/testing/src/execution_testing/client_clis/clis/geth.py

@@ -87,9 +87,6 @@ class GethExceptionMapper(ExceptionMapper):
         BlockException.SYSTEM_CONTRACT_CALL_FAILED: "system call failed to execute:",
         BlockException.INVALID_BLOCK_HASH: "blockhash mismatch",
         BlockException.RLP_BLOCK_LIMIT_EXCEEDED: "block RLP-encoded size exceeds maximum",
-        BlockException.INVALID_BAL_EXTRA_ACCOUNT: "BAL change not reported in computed",
-        BlockException.INVALID_BAL_MISSING_ACCOUNT: "additional mutations compared to BAL",
-        BlockException.INVALID_BLOCK_ACCESS_LIST: "unequal",
     }
     mapping_regex: ClassVar[Dict[ExceptionBase, str]] = {
         TransactionException.TYPE_3_TX_MAX_BLOB_GAS_ALLOWANCE_EXCEEDED: (
@@ -116,6 +113,19 @@ class GethExceptionMapper(ExceptionMapper):
         #
         # EELS definition for `is_valid_deposit_event_data`:
         # https://github.com/ethereum/execution-specs/blob/5ddb904fa7ba27daeff423e78466744c51e8cb6a/src/ethereum/forks/prague/requests.py#L51
+        # BAL Exceptions: TODO - review once all clients completed.
+        BlockException.INVALID_BAL_EXTRA_ACCOUNT: (
+            r"invalid block access list:"
+        ),
+        BlockException.INVALID_BAL_HASH: (r"invalid block access list:"),
+        BlockException.INVALID_BAL_MISSING_ACCOUNT: (
+            r"computed state diff contained mutated accounts which weren't reported in BAL"
+        ),
+        BlockException.INVALID_BLOCK_ACCESS_LIST: (
+            r"difference between computed state diff and BAL entry for account"
+            r"|invalid block access list:"
+        ),
+        BlockException.INCORRECT_BLOCK_FORMAT: (r"invalid block access list:"),
     }
 
 

packages/testing/src/execution_testing/client_clis/clis/nethermind.py

@@ -455,4 +455,19 @@ class NethermindExceptionMapper(ExceptionMapper):
         BlockException.SYSTEM_CONTRACT_CALL_FAILED: (
             r"(Withdrawals|Consolidations)Failed: Contract execution failed\."
         ),
+        # BAL Exceptions: TODO - review once all clients completed.
+        BlockException.INVALID_BAL_EXTRA_ACCOUNT: (
+            r"could not be parsed as a block: Could not decode block access list."
+        ),
+        BlockException.INVALID_BAL_HASH: (r"InvalidBlockLevelAccessListRoot:"),
+        BlockException.INVALID_BAL_MISSING_ACCOUNT: (
+            r"InvalidBlockLevelAccessListRoot:"
+        ),
+        BlockException.INVALID_BLOCK_ACCESS_LIST: (
+            r"InvalidBlockLevelAccessListRoot:"
+            r"|could not be parsed as a block: Could not decode block access list."
+        ),
+        BlockException.INCORRECT_BLOCK_FORMAT: (
+            r"could not be parsed as a block: Could not decode block access list."
+        ),
     }

packages/testing/src/execution_testing/client_clis/clis/reth.py

@@ -74,4 +74,18 @@ class RethExceptionMapper(ExceptionMapper):
         BlockException.INVALID_GAS_USED_ABOVE_LIMIT: (
             r"block used gas \(\d+\) is greater than gas limit \(\d+\)"
         ),
+        # BAL Exceptions: TODO - review once all clients completed.
+        BlockException.INVALID_BAL_EXTRA_ACCOUNT: (
+            r"Block BAL contains an account change that is not present in the computed BAL."
+        ),
+        BlockException.INVALID_BAL_HASH: (r"Block's access list is invalid."),
+        BlockException.INVALID_BAL_MISSING_ACCOUNT: (
+            r"Block BAL is missing an account change that is present in the computed BAL."
+        ),
+        BlockException.INVALID_BLOCK_ACCESS_LIST: (
+            r"Block's access list is invalid."
+        ),
+        BlockException.INCORRECT_BLOCK_FORMAT: (
+            r"Block's access list is invalid."
+        ),
     }