Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t8n tool improvements #1052

Open
gurukamath opened this issue Dec 11, 2024 · 2 comments
Open

t8n tool improvements #1052

gurukamath opened this issue Dec 11, 2024 · 2 comments
Labels
A-tool Area: tooling E-hard Experience: difficult, probably not for the faint of heart

Comments

@gurukamath
Copy link
Collaborator

The current t8n tool, although fully functional has a lot of room for improvement. An update /re-build of the tool might be in order. The following improvements would be good to have

  1. Updates to the specs are automatically reflected in the t8n tool without a need for explicitly updating it
  2. Improve tracing implementation
  3. Make the t8n tool code more maintainable. (re-factor/re-build components)
  4. Implement a tighter type system
  5. Reduce code duplication with other spec tools
@gurukamath gurukamath added A-tool Area: tooling E-hard Experience: difficult, probably not for the faint of heart labels Dec 11, 2024
@gurukamath gurukamath added this to the Post-Prague Re-factoring milestone Jan 29, 2025
@gurukamath
Copy link
Collaborator Author

Some re-factoring of the code is being considered which might impact this issue (potentially make the t8n improvements easier). See this for more details.

@marioevz
Copy link
Member

I would add to here (just to not creating a duplicate issue) to have better exception messages returned when a transaction in the list is invalid.

Right now we receive the same error for every different kind of exception:

"rejected": [
        {
            "index": "0x1",
            "error": "Failed transaction: "
        }
    ],

And in EEST we have a mapper to try to catch test errors when the error that the test triggers is not the error that needs to be hit by the test vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tool Area: tooling E-hard Experience: difficult, probably not for the faint of heart
Projects
None yet
Development

No branches or pull requests

2 participants