Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate utp failures: connection vs download, while tracing a query #1483

Open
carver opened this issue Sep 24, 2024 · 0 comments
Open

Comments

@carver
Copy link
Collaborator

carver commented Sep 24, 2024

A reasonable approach to this is to return a custom error type from the UtpController::connect_inbound_stream(). The error type can embed whether it failed during connection or download. Perhaps there are even more cases we want to track?

Then, with that error info, we can send the correct failure type to query_trace_events_tx in the overlay service.

This is a continuation of the work in #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant