Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo: KZG/Kzg Naming Inconsistencies #3656

Closed
holgerd77 opened this issue Sep 11, 2024 · 4 comments
Closed

Monorepo: KZG/Kzg Naming Inconsistencies #3656

holgerd77 opened this issue Sep 11, 2024 · 4 comments

Comments

@holgerd77
Copy link
Member

Guess we want the same as in #3632 for KZG (so: Kzg -> KZG + add to spell check)! 😋

@gabrocheleau Can you do that (as well)? 🙂

@gabrocheleau gabrocheleau changed the title Monorepo: KZG/Kzg Namining Inconsistencies Monorepo: KZG/Kzg Naming Inconsistencies Sep 11, 2024
@gabrocheleau
Copy link
Contributor

One limitation for KZG renaming will be that some of the actual methods live in another package (https://github.com/ethereumjs/kzg-wasm) @acolytec3 would you be able to do the renaming on that side & publish a new release? I can then update the monorepo dep and adjust.

@acolytec3
Copy link
Contributor

What should we do with this issue/PR. The new kzg library in micro-eth-signer we're using still has one instance of blobToKzgCommitment and that is reflected in our interface so we don't have to carry a wrapper construct around everywhere. Can we be content with that one discrepancy and make KZG capitalized everywhere else it appears?

@holgerd77
Copy link
Member Author

Sure

@gabrocheleau
Copy link
Contributor

This has been addressed (with one exception as mentioned above by @acolytec3 ) by #3674, therefore closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants