You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The wasm-opt Rust package is marked as optional - see here in the Rust build script - and build is also running if the package is not installed.
This is suboptimal since this bears the risk of doing releases without the optimization step. This should especially be avoided since - if we merge things to master on the monorepo side, this library will get published within the realm of our normal library stack.
So we should either make this mandatory by default in general or alternatively add a check later in the pipeline (when doing releases e.g., with a pre-publish hook or something?).
The text was updated successfully, but these errors were encountered:
The
wasm-opt
Rust package is marked as optional - see here in the Rust build script - and build is also running if the package is not installed.This is suboptimal since this bears the risk of doing releases without the optimization step. This should especially be avoided since - if we merge things to
master
on the monorepo side, this library will get published within the realm of our normal library stack.So we should either make this mandatory by default in general or alternatively add a check later in the pipeline (when doing releases e.g., with a pre-publish hook or something?).
The text was updated successfully, but these errors were encountered: