feat: config internal port mac with hashed br name

Signed-off-by: Changliang Wu <changliang.wu@smartx.com>

Author: wu-cl

ofctrl/ofctrl.go

@@ -382,18 +382,30 @@ func setDatapathID(conn *ovsdb.OvsdbClient, bridgeName string) error {
 	h := sha256.New()
 	h.Write([]byte(bridgeName))
 	datapathID := h.Sum(nil)[:8]
+	mac := net.HardwareAddr(h.Sum(nil)[:6])
+	mac[0] &^= 1
 
 	config, _ := ovsdb.NewOvsMap(map[string]string{"datapath-id": hex.EncodeToString(datapathID)})
-	operation := ovsdb.Operation{
+	operDpid := ovsdb.Operation{
 		Op:        "mutate",
 		Table:     "Bridge",
 		Where:     []interface{}{[]interface{}{"name", "==", bridgeName}},
 		Mutations: []interface{}{[]interface{}{"other_config", "insert", config}}, // never update the datapath id
 	}
-	_, err := ovsdbTransact(conn, "Open_vSwitch", operation)
 
+	operMac := ovsdb.Operation{
+		Op:        "mutate",
+		Table:     "Port",
+		Where:     []interface{}{[]interface{}{"name", "==", bridgeName}},
+		Mutations: []interface{}{[]interface{}{"mac", "insert", mac.String()}},
+	}
+	if _, err := ovsdbTransact(conn, "Open_vSwitch", operDpid, operMac); err != nil {
+		return err
+	}
+
+	log.Infof("bridge %s internal port mac (if exist) has been set to %s", bridgeName, mac.String())
 	log.Infof("bridge %s datapath id has been set to %s", bridgeName, hex.EncodeToString(datapathID))
-	return err
+	return nil
 }
 
 func ovsdbTransact(client *ovsdb.OvsdbClient, database string, operation ...ovsdb.Operation) ([]ovsdb.OperationResult, error) {

ofctrl/ofctrl_test.go

@@ -859,6 +859,10 @@ func TestNewOFController(t *testing.T) {
 	driver := ovsdbDriver.NewOvsDriver(bridgeName)
 	defer driver.Delete()
 
+	if err := driver.CreatePort(bridgeName, "internal", 0); err != nil {
+		t.Fatalf("fail to create default internal port : %s", err)
+	}
+
 	_ = NewOFController(&ofActor, uint16(rand.Intn(1024)), driver.OVSClient(), bridgeName)
 
 	//wait for 2sec
@@ -872,4 +876,8 @@ func TestNewOFController(t *testing.T) {
 	if config["datapath-id"] == "" {
 		t.Fatalf("datapath id must be set before connect to switch")
 	}
+
+	if mac, err := driver.GetInternalPortMac(); err != nil || mac == "" {
+		t.Fatalf("internal port mac must be set before connect to switch, err = %s", err)
+	}
 }

ovsdbDriver/ovsdbDriver.go

@@ -48,8 +48,7 @@ func NewOvsDriver(bridgeName string) *OvsDriver {
 	_ = ovs.MonitorAll("Open_vSwitch", "")
 
 	// Create the default bridge instance
-	err = ovsDriver.CreateBridge(ovsDriver.OvsBridgeName)
-	if err != nil {
+	if err = ovsDriver.CreateBridge(ovsDriver.OvsBridgeName); err != nil {
 		log.Fatalf("Error creating the default bridge. Err: %v", err)
 	}
 
@@ -183,9 +182,9 @@ func (self *OvsDriver) ovsdbTransact(ops []libovsdb.Operation) error {
 	// Parse reply and look for errors
 	for i, o := range reply {
 		if o.Error != "" && i < len(ops) {
-			return errors.New("OVS Transaction failed err " + o.Error + "Details: " + o.Details)
+			return errors.New("OVS Transaction failed err " + o.Error + "Details: " + o.Details + " UUID: " + o.UUID.GoUuid)
 		} else if o.Error != "" {
-			return errors.New("OVS Transaction failed err " + o.Error + "Details: " + o.Details)
+			return errors.New("OVS Transaction failed err " + o.Error + "Details: " + o.Details + " UUID: " + o.UUID.GoUuid)
 		}
 	}
 
@@ -345,6 +344,31 @@ func (self *OvsDriver) GetOtherConfig() (map[string]string, error) {
 	return buildMapFromOVSDBMap(externalIds), nil
 }
 
+func (self *OvsDriver) GetInternalPortMac() (string, error) {
+	selectOper := libovsdb.Operation{
+		Op:      "select",
+		Table:   "Port",
+		Where:   []interface{}{[]interface{}{"name", "==", self.OvsBridgeName}},
+		Columns: []string{"mac"},
+	}
+
+	opers := []libovsdb.Operation{selectOper}
+	ret, err := self.ovsClient.Transact("Open_vSwitch", opers...)
+	if err != nil {
+		return "", fmt.Errorf("ovsdb select internal port mac transaction failed: %v", opers)
+	}
+
+	if len(ret) == 0 || len(ret[0].Rows) == 0 {
+		return "", nil
+	}
+
+	mac, ok := ret[0].Rows[0]["mac"].(string)
+	if !ok {
+		return "", nil
+	}
+	return mac, nil
+}
+
 func (self *OvsDriver) SetExternalIds(externalIds map[string]string) error {
 	oMap := buildOVSDBMapFromMap(externalIds)
 	row := make(map[string]interface{})
@@ -406,8 +430,8 @@ func (self *OvsDriver) UpdateInterface(ifaceName string, externalIDs map[string]
 
 // Create an internal port in OVS
 func (self *OvsDriver) CreatePort(intfName, intfType string, vlanTag uint) error {
-	portUuidStr := intfName
-	intfUuidStr := fmt.Sprintf("Intf%s", intfName)
+	portUuidStr := "portdummy"
+	intfUuidStr := "ifacedummy"
 	portUuid := []libovsdb.UUID{{GoUuid: portUuidStr}}
 	intfUuid := []libovsdb.UUID{{GoUuid: intfUuidStr}}
 	opStr := "insert"