From 3a77b83dfc20bcb1359823039c34d93e7c4cd86e Mon Sep 17 00:00:00 2001 From: richelbilderbeek Date: Fri, 27 Dec 2024 12:02:29 +0100 Subject: [PATCH 1/3] Test that returned tables have at least 1 row --- tests/testthat/test-get_lyrics.R | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/testthat/test-get_lyrics.R b/tests/testthat/test-get_lyrics.R index f9a4099..623411a 100644 --- a/tests/testthat/test-get_lyrics.R +++ b/tests/testthat/test-get_lyrics.R @@ -26,7 +26,7 @@ test_that("get_lyrics_url returns the right output formats", { expect_is(output, "tbl") expect_is(output, "data.frame") expect_setequal(output$song_lyrics_url, url) - + expect_true(nrow(output) > 0) }) test_that("get_lyrics_search returns the right output formats", { @@ -38,4 +38,5 @@ test_that("get_lyrics_search returns the right output formats", { expect_is(output, "tbl_df") expect_is(output, "tbl") expect_is(output, "data.frame") + expect_true(nrow(output) > 0) }) From 8ad6fa4da351b25f698ebb1c8b7d6e6d38a75f65 Mon Sep 17 00:00:00 2001 From: richelbilderbeek Date: Fri, 27 Dec 2024 13:37:38 +0100 Subject: [PATCH 2/3] EOD --- geniusr.Rproj | 1 + 1 file changed, 1 insertion(+) diff --git a/geniusr.Rproj b/geniusr.Rproj index cba1b6b..9d31f51 100644 --- a/geniusr.Rproj +++ b/geniusr.Rproj @@ -1,4 +1,5 @@ Version: 1.0 +ProjectId: 13d7aea2-2c9d-47ac-b580-57ccfec2d156 RestoreWorkspace: No SaveWorkspace: No From 33a0ced47e6389a10032b899a62fe3cdaab5e61d Mon Sep 17 00:00:00 2001 From: richelbilderbeek Date: Tue, 29 Apr 2025 12:04:40 +0200 Subject: [PATCH 3/3] Use 'actions/checkout@v4' --- .github/workflows/pkgdown.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pkgdown.yaml b/.github/workflows/pkgdown.yaml index 3efd117..6748ae4 100644 --- a/.github/workflows/pkgdown.yaml +++ b/.github/workflows/pkgdown.yaml @@ -20,7 +20,7 @@ jobs: env: GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - uses: r-lib/actions/setup-pandoc@v2