Refactoring/403 drop support for turbodbc (#648)

* Drop support for turbodbc

Author: ArBridgeman

.github/dependabot.yml

@@ -24,5 +24,3 @@ updates:
           - "*"
         exclude-patterns:
           - "sqlalchemy"
-          - "turbodbc"
-

README.rst

@@ -55,7 +55,7 @@ ODBC-based dialects demand a thorough understanding of (Unix)ODBC, and the setup
 
 .. warning::
 
-    The maintenance of Turbodbc & pyodbc support is currently paused, and it is planned to be phased out in future versions.
+    The maintenance of pyodbc support is currently paused, and it is planned to be phased out in future versions.
 
 
 System Requirements

doc/changes/unreleased.md

@@ -1,5 +1,7 @@
 # Unreleased
 
+In this release, the ODBC-dialect Turbodbc was dropped.
+
 ## Refactoring
 
 - #621: Added `future=true` to `create_engine` to use the 2.0 API
@@ -14,3 +16,4 @@
 - #631: Updated `EXADialect.has_table` to search for both tables and views, fixed passing of schema=None to dialect methods, and reinstated `sqlalchemy` tests:
   - `ReturningGuardsTest` are used to indicate that the Exasol dialect, which does not natively support the [RETURNING clause](https://docs.sqlalchemy.org/en/20/glossary.html#term-RETURNING), is set up per the API specifications
   - `ComponentReflectionTest.test_not_existing_table` is used to indicate that specific `EXADialect` methods (i.e. `get_columns`) check to see if the requested table/view exists and if not, they will now toss a `NoSuchTableError` exception
+- #403: Dropped support for Turbodbc

doc/developer_guide/developer_guide.rst

@@ -141,11 +141,6 @@ Tests
 
         nox -s "verify(connector='pyodbc')"
 
-#. Run all tests with `turbodbc` connector
-
-    .. code-block::
-
-        nox -s "verify(connector='turbodbc')"
 
 .. attention::
 

doc/user_guide.rst

@@ -61,8 +61,6 @@ Getting Started
    .. code-block:: shell
 
       pip install "sqlalchemy-exasol[pydobc]"
-      pip install "sqlalchemy-exasol[turbodbc]"
-
 
 Further Examples
 ~~~~~~~~~~~~~~~~
@@ -120,7 +118,7 @@ Websocket-based Dialect
 
 .. note::
    Validation with fingerprint is only supported in the Websocket-based dialect, and not
-   the ODBC-based dialects (Pyodbc, Turbodbc).
+   the ODBC-based dialect (Pyodbc).
 
 
 Pyodbc-based Dialect
@@ -142,26 +140,6 @@ Pyodbc-based Dialect
     with engine.connect() as con:
         result = con.execute(sql.text(query)).fetchall()
 
-
-Turbo-based Dialect
----------------------
-
-.. code-block:: python
-
-    from sqlalchemy import create_engine, sql
-
-    user = "sys"
-    password = "exasol"
-    host = "127.0.0.1"
-    port = "8563
-    schema = "my_schema
-
-    url = f"exa+turbodbc://{user}:{password}@{host}:{port}/{schema}?CONNECTIONLCALL=en_US.UTF-8&driver=EXAODBC"
-    engine = create_engine(url)
-    query = "select 42 from dual"
-    with engine.connect() as con:
-        result = con.execute(sql.text(query)).fetchall()
-
 General Notes
 ~~~~~~~~~~~~~
 

noxconfig.py

@@ -51,7 +51,7 @@ class Config(BaseConfig):
     environment_name: str = "test"
     db_port: int = 8563
     bucketfs_port: int = 2580
-    connectors: list[str] = ["pyodbc", "turbodbc", "websocket"]
+    connectors: list[str] = ["pyodbc", "websocket"]
     plugins: list = [StartDB, StopDB]
 
 

poetry.lock

@@ -64,12 +64,10 @@ packaging = ">=21.3"
 pyexasol = ">=0.26.0,<2"
 sqlalchemy = "^2.0.0"
 
-turbodbc = { version = "==4.5.4", optional = true }
 pyodbc = { version = ">=4.0.34,<6", optional = true }
 
 [tool.poetry.extras]
 pyodbc = ["pyodbc"]
-turbodbc = ["turbodbc"]
 
 [tool.poetry.group.dev.dependencies]
 nox = ">=2022.1.7"
@@ -85,7 +83,6 @@ exasol-toolbox = "^1.12.0"
 
 [tool.poetry.plugins."sqlalchemy.dialects"]
 "exa.pyodbc" = "sqlalchemy_exasol.pyodbc:EXADialect_pyodbc"
-"exa.turbodbc" = "sqlalchemy_exasol.turbodbc:EXADialect_turbodbc"
 "exa.websocket" = "sqlalchemy_exasol.websocket:EXADialect_websocket"
 
 
@@ -94,9 +91,9 @@ addopts = "--tb native -v -r fxX"
 filterwarnings = [
 "error",
 "ignore::pytest.PytestUnraisableExceptionWarning",
-# this is used for turbodbc and pyodbc as historically we'd like to remove them.
+# this is used for pyodbc as historically we'd like to remove this.
 # thus far, it seems like this is not a strict requirement for the migration,
-# so we will ignore them.
+# so we will ignore this.
 "ignore::sqlalchemy_exasol.warnings.SqlaExasolDeprecationWarning"
 ]
 markers = [

pyproject.toml

@@ -49,7 +49,7 @@ def skipped_test_from(obj: dict[str, Any]) -> Test:
 
 def _create_parser() -> ArgumentParser:
     parser = ArgumentParser(formatter_class=ArgumentDefaultsHelpFormatter)
-    parser.add_argument("connector", choices=["pyodbc", "turbodbc"])
+    parser.add_argument("connector", choices=["pyodbc"])
     parser.add_argument("test_results")
     parser.add_argument("-o", "--output", type=FileType("w"), default="-")
     parser.add_argument("-f", "--format", choices=["human", "csv"], default="csv")

scripts/report.py

@@ -1,9 +1,7 @@
 [db]
 exasol-pyodbc=exa+pyodbc://sys:exasol@localhost:8563/TEST?CONNECTIONCALL=en_US.UTF-8&DRIVER=EXAODBC&SSLCertificate=SSL_VERIFY_NONE
-exasol-turbodbc=exa+turbodbc://sys:exasol@localhost:8563/TEST?CONNECTIONCALL=en_US.UTF-8&DRIVER=EXAODBC&SSLCertificate=SSL_VERIFY_NONE
 exasol-websocket=exa+websocket://sys:exasol@localhost:8563/TEST?CONNECTIONCALL=en_US.UTF-8&DRIVER=EXAODBC&SSLCertificate=SSL_VERIFY_NONE
 
 [sqla_testing]
 requirement_cls=sqlalchemy_exasol.requirements:Requirements
 profile_file=.profiles.txt
-