Web applications part 1 (Browser.sandbox) #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to create introduction.mdonce about.md has been through review
Its numbers and not letters, but not too bad
Now it handles the case when the name of the primary file (src/Main.elm) doesn't match the solution name. This is a good convention, but doesn't work for the web applications concept where the primary file must be called Main.elm to work with elm-test and elm-make and similar
Not sure it is going to work though
This reverts commit 5532072.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639
Replaces the previous draft PR #723 where there is a lot of discussion about how and what to do.
I'll do the introduction.mds from about once people are happy with it.
We could also add a css file so that it looks a bit nicer if you run it locally, but not sure if its worth it.
At the moment the test runner is failing, which took me a little head scratching. Its because the test runner doesn't have the dependencies installed I think (although I thought it would have, as html was already an indirect dependency, but anyway).
So we need to do a new release of the elm-test-runner, but its gets its dependencies from the template/elm.json file in this repo
(https://github.com/exercism/elm-test-runner/blob/8262e8e15c86773353e61a969e9ffaa7af53dc3c/Dockerfile#L29)
So maybe I should create a new PR in this repo, just updating the template/elm.json (and all the other elm.json's), which would hopefully pass, then create a new release of the test runner, which would use the new file, and then come back to this PR.
I'm happy to hear other thoughts? Seems like something we should document for next time.