Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate-practice-exercise script #115

Open
loziniak opened this issue Dec 1, 2023 · 3 comments
Open

Update generate-practice-exercise script #115

loziniak opened this issue Dec 1, 2023 · 3 comments

Comments

@loziniak
Copy link
Member

loziniak commented Dec 1, 2023

In #102 there were updates to .meta/config.json files, source and source_url fields were added. Perhaps something more?

We need to check _tools/generate-practice-exercise.red script and _templates/practice-exercise folder and update them to reflect recent changes.

@loziniak loziniak changed the title Update *generate-practice-exercise* script Update _generate-practice-exercise_ script Dec 1, 2023
@loziniak loziniak changed the title Update _generate-practice-exercise_ script Update generate-practice-exercise script Dec 1, 2023
@loziniak
Copy link
Member Author

loziniak commented Dec 1, 2023

Also relevant may be #109 and #110 .

@loziniak
Copy link
Member Author

loziniak commented Dec 1, 2023

And tests metadata could also be updated, like in #103 .

@BNAndras
Copy link
Member

I noticed that the script adds canonical cases for tests that are re-implemented by another test. The script should use tests.toml and ignore tests that come with include = false. When sourced directly from the problem specifications, those are tests that have a replacement test further down in the file. We don't need to track what test replaces what though. Just ignore any test with include = false. Tests can also be manually marked as not included if we don't want to implement them for a track, but that'd be after the exercise is generated. Therefore, that's not relevant.

[919f8ef0-b767-4d1b-8516-6379d07fcb28]
description = "disallow first strand longer"
include = false

[b9228bb1-465f-4141-b40f-1f99812de5a8]
description = "disallow first strand longer"
reimplements = "919f8ef0-b767-4d1b-8516-6379d07fcb28"

In this snippet, the first test should be ignored. The second test should just be seen as a regular test to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants