Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily revert new loss implementations #916

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Temporarily revert new loss implementations #916

merged 2 commits into from
Jan 8, 2024

Conversation

danieldk
Copy link
Contributor

Description

Temporarily revert new loss implementations for the more limited scope v9.

Types of change

Maintenance

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@danieldk danieldk added feat / loss Loss functions 🔜 v9.0 Related to upcoming v9.0 labels Dec 21, 2023
@danieldk danieldk force-pushed the maintenance/backout-losses branch from c4c4a94 to 0d77038 Compare December 21, 2023 13:28
@danieldk danieldk marked this pull request as ready for review December 21, 2023 13:42
svlandeg
svlandeg reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is difficult to review, but nothing jumps out at me. As internally discussed, let's keep this functionality for v10 so we don't lose this work.

@danieldk danieldk merged commit 816ea33 into explosion:v9 Jan 8, 2024
@danieldk danieldk deleted the maintenance/backout-losses branch January 8, 2024 15:50
@danieldk
Copy link
Contributor Author

danieldk commented Jan 8, 2024

The new losses are now in https://github.com/explosion/thinc/tree/v10 , getting ready for the subsequent major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

Assignees
No one assigned
Labels
feat / loss Loss functions 🔜 v9.0 Related to upcoming v9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieldk @svlandeg