[Bug] Save feature deletes user's entry after "MAPXX"

[dftf-stu]

Background

Version of Crispy Doom: 5.10.3
Operating System: Windows 10 21H2 (64-bit; non-ARM)
Game: PLUTONIA
Any loaded WADs and mods (please include full command line):
crispy-doom.exe -IWAD PLUTONIA.wad -MERGE -FILE FDDM0121.wad FDP_0121.wad -DEH FDDM0121.deh -SAVEDIR SAVES\FDID_PLU

Bug description

Steps to reproduce:

1. During a game press ESCAPE (or your Menu key) then go to Save Game
2. Pick any slot, and type some custom text after the default entry (for example, after "MAP02" I would type "Current Position" which names the entry "MAP02 Current Position" )
3. After saving, the gameplay resumes
4. Go back into the Menu, then again to "Save Game"
5. Select the same save-slot you used above, then press ENTER
6. Your custom text gets erased, and it goes back to "MAPXX"

Expected behaviour:

If the user has entered additional text after the MAPXX reference, this text should not get erased, surely?

Workaround?

As a workaround, you can use different text at the beginning: for example, instead of "MAP02" change it to "LEV02".

Screenshots:

Above: the default name for the save on the second map I am on is "MAP02". I have typed "Current Position" after this.

Above: after saving, go back into the Menu then to "Save Game". The custom text I added has been retained...

Above: ...however, the moment I press ENTER to overwrite the save, it deletes all text after "MAP02".

[fabiangreffrath]

I wouldn't say it's a bug but rather a feature that got in your way. Things get interesting if you save a game in a map loaded from a PWAD. Then the PWAD name will be appended to the map name in parentheses, e.g. "MAP01 (icarus.wad)". However, this means that i cannot even say that a savegame name may not get overridden if there is some additional text after the map identifier. So, currently my best bet us that if the savegame name starts with a map identifier, then it's free to be overridden.

[dftf-stu]

[...] the PWAD name will be appended to the map name in parentheses, e.g. "MAP01 (icarus.wad)"

So in my example, shouldn't my save name default to "MAP02 (FDDM0121.wad)" or "MAP02 (FDP_0121.wad)"? (I'm not sure with multiple PWADs whether it would go by the first or last wad in the command-line to derive the name from?).

Or does this only work when only a single PWAD file is used, not multiple?

[fabiangreffrath]

It appends the name of the PWAD the map is loaded from. If you load a texture or music pack this won't make a difference.