validate seconds_per_time_unit (#157)

* check for valid values of seconds_per_time_unit

* clean up initialize_global

Author: jornbr

src/builtin/time_filter.F90

@@ -211,10 +211,11 @@ subroutine horizontal_temporal_maximum_initialize(self, configunit)
    subroutine interior_temporal_mean_set_data(self, store, seconds_per_time_unit)
       class (type_interior_temporal_mean), intent(inout) :: self
       type (type_store), target                          :: store
-      real(rke), intent(in)                              :: seconds_per_time_unit
+      real(rke), optional, intent(in)                    :: seconds_per_time_unit
 
       integer :: ibin
 
+      if (.not. present(seconds_per_time_unit)) call self%fatal_error('interior_temporal_mean_set_data', 'host did not provide time information.')
       self%source%icatalog = self%source%link%target%catalog_index
       self%window = self%window / seconds_per_time_unit
       do ibin = 1, size(self%history)
@@ -344,10 +345,11 @@ subroutine interior_temporal_mean_update(self, catalog _POSTARG_LOCATION_RANGE_,
    subroutine horizontal_temporal_mean_set_data(self, store, seconds_per_time_unit)
       class (type_horizontal_temporal_mean), intent(inout) :: self
       type (type_store), target                            :: store
-      real(rke), intent(in)                                :: seconds_per_time_unit
+      real(rke), optional, intent(in)                      :: seconds_per_time_unit
 
       integer :: ibin
 
+      if (.not. present(seconds_per_time_unit)) call self%fatal_error('horizontal_temporal_mean_set_data', 'host did not provide time information.')
       self%source%icatalog = self%source%link%target%catalog_index
       self%window = self%window / seconds_per_time_unit
       do ibin = 1, size(self%history)
@@ -477,10 +479,11 @@ end subroutine horizontal_temporal_mean_update
    subroutine horizontal_temporal_maximum_set_data(self, store, seconds_per_time_unit)
       class (type_horizontal_temporal_maximum), intent(inout) :: self
       type (type_store), target                               :: store
-      real(rke), intent(in)                                   :: seconds_per_time_unit
+      real(rke), optional, intent(in)                         :: seconds_per_time_unit
 
       integer :: ibin
 
+      if (.not. present(seconds_per_time_unit)) call self%fatal_error('horizontal_temporal_maximum_set_data', 'host did not provide time information.')
       self%source%icatalog = self%source%link%target%catalog_index
       self%window = self%window / seconds_per_time_unit
       do ibin = 1, size(self%history)

src/fabm.F90

@@ -683,7 +683,10 @@ subroutine set_domain(self _POSTARG_LOCATION_, seconds_per_time_unit)
       self%domain%horizontal_shape(:) = (/_HORIZONTAL_LOCATION_/)
 #endif
 
-      if (present(seconds_per_time_unit)) self%seconds_per_time_unit = seconds_per_time_unit
+      if (present(seconds_per_time_unit)) then
+         if (seconds_per_time_unit <= 0.0_rke) call fatal_error('set_domain', 'seconds_per_time_unit must be positive if provided.')
+         self%seconds_per_time_unit = seconds_per_time_unit
+      end if
    end subroutine set_domain
 
 #if _FABM_DIMENSION_COUNT_>0
@@ -905,7 +908,11 @@ subroutine start(self)
       call cache_create(self%domain, self%cache_fill_values, self%cache_hz)
       call cache_create(self%domain, self%cache_fill_values, self%cache_vert)
 
-      call initialize_global(self%root)
+      if (self%seconds_per_time_unit == 0.0_rke) then
+         call initialize_global(self%root)
+      else
+         call initialize_global(self%root, self%seconds_per_time_unit)
+      end if
 
       ! For diagnostics that are not needed, set their write index to 0 (rubbish bin)
       if (self%log) then
@@ -998,20 +1005,21 @@ subroutine flag_variables_with_data(variable_list, data_sources)
          end do
       end subroutine
 
-      recursive subroutine initialize_global(model)
+      recursive subroutine initialize_global(model, seconds_per_time_unit)
          class (type_base_model), intent(inout) :: model
+         real(rke), optional, intent(in)        :: seconds_per_time_unit
 
          type (type_model_list_node), pointer :: child
 
          select type (model)
          class is (type_global_model)
-            call model%set_data(self%store, self%seconds_per_time_unit)
+            call model%set_data(self%store, seconds_per_time_unit)
          end select
 
          ! Process children
          child => model%children%first
          do while (associated(child))
-            call initialize_global(child%model)
+            call initialize_global(child%model, seconds_per_time_unit)
             child => child%next
          end do
       end subroutine

src/fabm_global_types.F90

@@ -113,7 +113,7 @@ module fabm_global_types
    subroutine set_data(self, store, seconds_per_time_unit)
       class (type_global_model), intent(inout) :: self
       type (type_store), target                :: store
-      real(rke), intent(in)                    :: seconds_per_time_unit
+      real(rke), optional, intent(in)          :: seconds_per_time_unit
    end subroutine
 
    subroutine update(self, catalog _POSTARG_LOCATION_RANGE_, time)