From 80c40c6f352af88c08f96406c9c63f4a5a13572c Mon Sep 17 00:00:00 2001
From: Moti Zilberman <motiz88@gmail.com>
Date: Wed, 15 Aug 2018 15:56:42 +0100
Subject: [PATCH] Remove empty string from React DOM booleans/enums

This is a design choice documented in
https://github.com/facebook/flow/pull/6727#user-content-forbid-empty-string
---
 lib/react-dom.js                           | 6 ++----
 tests/react_dom/props_boolean.js           | 2 +-
 tests/react_dom/props_booleanish_string.js | 2 +-
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/lib/react-dom.js b/lib/react-dom.js
index 9e7da2499b6..0d200f3d55f 100644
--- a/lib/react-dom.js
+++ b/lib/react-dom.js
@@ -619,7 +619,7 @@ type ReactDOM$HTMLElementProps = ReactDOM$ElementProps & {
   spellCheck?: ReactDOM$BooleanishString,
   suppressContentEditableWarning?: boolean,
   title?: string,
-  translate?: $TODO$CaseInsensitive<"" | "yes" | "no">
+  translate?: $TODO$CaseInsensitive<"yes" | "no">
 };
 
 type ReactDOM$SVGElementProps = ReactDOM$ElementProps & {
@@ -641,12 +641,10 @@ type ReactDOM$SVGElementProps = ReactDOM$ElementProps & {
 };
 
 type ReactDOM$BooleanishString =
-  | ""
   | $TODO$CaseInsensitive<"true" | "false">
   | boolean;
 
-type ReactDOM$Boolean<AttributeName: string = ""> =
-  | ""
+type ReactDOM$Boolean<AttributeName: string> =
   | $TODO$CaseInsensitive<AttributeName>
   | boolean;
 
diff --git a/tests/react_dom/props_boolean.js b/tests/react_dom/props_boolean.js
index eff01bd92c1..5bee52c2d2c 100644
--- a/tests/react_dom/props_boolean.js
+++ b/tests/react_dom/props_boolean.js
@@ -7,7 +7,7 @@ import React from "react";
 <span hidden={null} />; // Error: Expected DOM boolean
 <span hidden="true" />; // Error: Expected DOM boolean
 <span hidden="false" />; // Error: Expected DOM boolean
-<span hidden="" />; // OK
+<span hidden="" />; // Error: Expected DOM boolean
 <span hidden="yes" />; // Error: Expected DOM boolean
 <span hidden="hidden" />; // OK
 
diff --git a/tests/react_dom/props_booleanish_string.js b/tests/react_dom/props_booleanish_string.js
index 17d3947bc94..51fc0d42377 100644
--- a/tests/react_dom/props_booleanish_string.js
+++ b/tests/react_dom/props_booleanish_string.js
@@ -7,6 +7,6 @@ import React from "react";
 <div contentEditable={null} />; // Error: Expected booleanish string
 <div contentEditable="true" />; // OK
 <div contentEditable="false" />; // OK
-<div contentEditable="" />; // OK
+<div contentEditable="" />; // Error: Expected booleanish string
 <div contentEditable="yes" />; // Error: Expected booleanish string
 <div contentEditable="contentEditable" />; // Error: Expected booleanish string