Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: HorizontalRuleNode breaks TableCell in some case #6459

Closed
turnerguo opened this issue Jul 25, 2024 · 3 comments · May be fixed by #6598
Closed

Bug: HorizontalRuleNode breaks TableCell in some case #6459

turnerguo opened this issue Jul 25, 2024 · 3 comments · May be fixed by #6598

Comments

@turnerguo
Copy link
Contributor

Lexical version:

Steps To Reproduce

  1. insert a HorizontalRuleNode in table.
  2. select above blank paragraph before HorizontalRuleNode and press delete key
  3. the empty paragraph will deleted, keep press delete key the TableCell will deleted too, see the video on detail.
iShot_2024-07-24_14.50.22.mp4
@etrepum
Copy link
Collaborator

etrepum commented Dec 2, 2024

This no longer reproduces in the same way, but there are still some edge cases here because once the divider is deleted you can enter text directly into the TableCellNode, it does not create a wrapping ParagraphNode.

@ivailop7
Copy link
Collaborator

ivailop7 commented Jan 5, 2025

This no longer reproduces in the same way, but there are still some edge cases here because once the divider is deleted you can enter text directly into the TableCellNode, it does not create a wrapping ParagraphNode.

I'm no longer able to reproduce this issue, I see even after deleting the horizontal line, it does insert a paragraph. I guess you've added a transform in the big tables rewrite?

@etrepum
Copy link
Collaborator

etrepum commented Jan 5, 2025

@etrepum etrepum closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants