feat(core): add config to skip waiting for browser close

Author: Eryk Kolodziej

packages/core/src/lib/Config.ts

@@ -8,7 +8,7 @@
  * @oncall web_perf_infra
  */
 
-import type {Permission} from 'puppeteer';
+import type { Permission } from 'puppeteer';
 import type {
   AnyFunction,
   FileOption,
@@ -28,8 +28,8 @@ import path from 'path';
 import modes from '../modes/RunningModes';
 import info from './Console';
 import constant from './Constant';
-import fileManager, {FileManager} from './FileManager';
-import {setInternalValue} from './InternalValueSetter';
+import fileManager, { FileManager } from './FileManager';
+import { setInternalValue } from './InternalValueSetter';
 
 interface Device {
   name: string;
@@ -240,6 +240,7 @@ export class MemLabConfig {
   noReCluster: boolean;
   maxSamplesForClustering: number;
   filterTraceByName: Nullable<string>;
+  skipBrowserCloseWait: boolean;
 
   constructor(options: ConfigOption = {}) {
     // init properties, they can be configured manually
@@ -370,6 +371,8 @@ export class MemLabConfig {
     // if specified via CLI options, this will filter leak traces by
     // node and edge names in the leak trace
     this.filterTraceByName = null;
+    // if true, memlab will not wait for the browser to close successfully
+    this.skipBrowserCloseWait = false;
   }
 
   // initialize configurable parameters
@@ -554,7 +557,7 @@ export class MemLabConfig {
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     _app: string,
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    _interaction: string,
+    _interaction: string
   ): string[] {
     return [];
   }
@@ -576,14 +579,14 @@ export class MemLabConfig {
 
   public static resetConfigWithTransientDir(): MemLabConfig {
     const config = MemLabConfig.getInstance();
-    fileManager.initDirs(config, {transient: true});
+    fileManager.initDirs(config, { transient: true });
     return config;
   }
 
   private haltOrThrow(
     msg: string,
     // eslint-disable-next-line @typescript-eslint/no-empty-function
-    secondaryPrintCallback: AnyFunction = () => {},
+    secondaryPrintCallback: AnyFunction = () => {}
   ): void {
     if (this.errorHandling === ErrorHandling.Halt) {
       info.error(msg);
@@ -608,7 +611,7 @@ export class MemLabConfig {
     const externalFilter: ILeakFilter = {};
 
     // set leak filter
-    const {leakFilter, beforeLeakFilter, retainerReferenceFilter} = scenario;
+    const { leakFilter, beforeLeakFilter, retainerReferenceFilter } = scenario;
     if (typeof leakFilter === 'function') {
       hasCallback = true;
       externalFilter.leakFilter = leakFilter;
@@ -647,8 +650,8 @@ export class MemLabConfig {
       this.haltOrThrow(
         `Invalid browser: ${v} ` +
           `(supported browsers: ${Object.keys(constant.supportedBrowsers).join(
-            ', ',
-          )})`,
+            ', '
+          )})`
       );
     }
     this._browser = constant.supportedBrowsers[v];
@@ -730,7 +733,7 @@ export class MemLabConfig {
 
   setDevice(
     deviceName: string,
-    options: {manualOverride?: boolean} = {},
+    options: { manualOverride?: boolean } = {}
   ): void {
     if (!options.manualOverride && this._deviceManualOverridden) {
       return;
@@ -747,8 +750,8 @@ export class MemLabConfig {
     const name = deviceName.split('-').join(' ');
     if (!devices[name]) {
       const supportedDevices = Array.from(Object.keys(devices))
-        .filter(name => isNaN(parseInt(name, 10)))
-        .map(name => name.split(' ').join('-'));
+        .filter((name) => isNaN(parseInt(name, 10)))
+        .map((name) => name.split(' ').join('-'));
       this.haltOrThrow(`Invalid device: ${name}`, () => {
         info.lowLevel(`(supported devies: ${supportedDevices.join(', ')})`);
       });

packages/core/src/lib/Utils.ts

@@ -1325,6 +1325,8 @@ async function closePuppeteer(
   if (config.isLocalPuppeteer && !options.warmup) {
     await Promise.all(pages.map(page => page.close()));
     await browser.disconnect();
+  } else if (config.skipBrowserCloseWait === true) {
+    browser.close();
   } else {
     await browser.close();
   }