Skip to content

Commit 62616ab

Browse files
rubennortemeta-codesync[bot]
authored andcommitted
Make useConcurrentRoot always true in renderElement (#56562)
Summary: Pull Request resolved: #56562 Changelog: [Internal] All apps have migrated to concurrent root (as they're using Fabric), so the `useConcurrentRoot` parameter is no longer needed. This removes `useConcurrentRoot` (and `useFabric`) from `renderElement` in `RendererImplementation` and the profiling variant, hardcoding the underlying call to `true`, and stops passing them from `renderApplication`. Reviewed By: javache Differential Revision: D101981133
1 parent d3c297e commit 62616ab

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

packages/react-native/Libraries/ReactNative/RendererImplementation.js

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,23 +57,25 @@ let cachedFabricRender;
5757
export function renderElement({
5858
element,
5959
rootTag,
60-
useFabric,
61-
useConcurrentRoot,
6260
}: {
6361
element: React.MixedElement,
6462
rootTag: number,
65-
useFabric: boolean,
66-
useConcurrentRoot: boolean,
6763
}): void {
6864
if (cachedFabricRender == null) {
6965
cachedFabricRender = getFabricRenderer().render;
7066
}
7167

72-
cachedFabricRender(element, rootTag, null, useConcurrentRoot, {
73-
onCaughtError,
74-
onUncaughtError,
75-
onRecoverableError,
76-
});
68+
cachedFabricRender(
69+
element,
70+
rootTag,
71+
/* callback */ null,
72+
/* useConcurrentRoot */ true,
73+
{
74+
onCaughtError,
75+
onUncaughtError,
76+
onRecoverableError,
77+
},
78+
);
7779
}
7880

7981
let cachedFabricDispatchCommand;

packages/react-native/Libraries/ReactNative/renderApplication.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,6 @@ export default function renderApplication<Props extends Object>(
9797
Renderer.renderElement({
9898
element: renderable,
9999
rootTag,
100-
useFabric: true,
101-
useConcurrentRoot: true,
102100
});
103101
performanceLogger.stopTimespan('renderApplication_React_render');
104102
}

0 commit comments

Comments
 (0)