Simplify RendererProxy and RendererImplementation to Fabric-only (#56556) by rubennorte · Pull Request #56556 · facebook/react-native

rubennorte · 2026-04-22T11:29:28Z

Summary:

Changelog: [internal]

All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure.

This commit simplifies:

RendererImplementation.js: Rewritten to only use Fabric renderer
RendererProxy.fb.js: Removed Paper-related exports
RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production)
FabricRendererImplementationWithProfiling.js: Removed Paper shims
Jest mock RendererProxy.js: Removed Paper exports

Reviewed By: javache

Differential Revision: D101353113

meta-codesync · 2026-04-22T11:29:36Z

@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101353113.

…ebook#56556) Summary: Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Differential Revision: D101353113

…ebook#56556) Summary: Pull Request resolved: facebook#56556 Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Differential Revision: D101353113

…ebook#56556) Summary: Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Differential Revision: D101353113

…ebook#56556) Summary: Pull Request resolved: facebook#56556 Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Differential Revision: D101353113

…ebook#56556) Summary: Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Reviewed By: javache Differential Revision: D101353113

…ebook#56556) Summary: Pull Request resolved: facebook#56556 Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Reviewed By: javache Differential Revision: D101353113

…ebook#56556) Summary: Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Reviewed By: javache Differential Revision: D101353113

…ebook#56556) Summary: Pull Request resolved: facebook#56556 Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Reviewed By: javache Differential Revision: D101353113

Summary: Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one. Changes in `TextInput-itest.js`: - Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused"). - Add a top-level `has the correct displayName` test. - Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`: - `id and nativeID`: `id` → `nativeID` mapping, `nativeID` pass-through, and `id` precedence over `nativeID`. - `testID`: pass-through. - `aria-label and accessibilityLabel`: `aria-label` → `accessibilityLabel` mapping and `accessibilityLabel` pass-through. - `aria-* and accessibilityState`: `aria-busy/checked/disabled/expanded/selected` mapped into `accessibilityState`. - `accessibilityRole`: pass-through. - `style`: `backgroundColor` propagated as a native color value. Tests intentionally NOT ported: - Inherited `HostInstance` method presence checks (`focus`, `blur`, `setNativeProps`, `measure`, `measureInWindow`, `measureLayout`): they are guaranteed by Flow typing on `ReactNativeElement`, exercised in `ReactNativeElement-itest.js`, and Flow's `method-unbinding` rule prevents the simple `toBeInstanceOf(Function)` check without `$FlowFixMe` (which is forbidden by project rules). - `focus() should not do anything if the TextInput is not editable`: `TextInputState.focusTextInput` reads `textField.currentProps?.editable`, but in the new architecture `currentProps` is not exposed on the public `ReactNativeElement` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching `currentProps`. Documenting this as expected behavior in Fantom would mask a real bug. - `should give precedence to textContentType when set`: `textContentType` is iOS-only and Fantom defaults to Android (`AndroidTextInput`). Files removed: - `Libraries/Components/TextInput/__tests__/TextInput-test.js` - `Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap` Changelog: [Internal] Differential Revision: D101977225

…ebook#56556) Summary: Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Reviewed By: javache Differential Revision: D101353113

…ebook#56556) Summary: Pull Request resolved: facebook#56556 Changelog: [internal] All Meta apps have migrated to Fabric, so we no longer need to support Paper in the renderer infrastructure. This commit simplifies: - RendererImplementation.js: Rewritten to only use Fabric renderer - RendererProxy.fb.js: Removed Paper-related exports - RendererProxy.js: Updated comment to reflect Fabric variants (profiling vs production) - FabricRendererImplementationWithProfiling.js: Removed Paper shims - Jest mock RendererProxy.js: Removed Paper exports Reviewed By: javache Differential Revision: D101353113

meta-codesync · 2026-04-23T13:10:16Z

This pull request has been merged in 1a623a8.

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2026

facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels Apr 22, 2026

meta-codesync Bot added fb-exported meta-exported labels Apr 22, 2026

meta-codesync Bot changed the title ~~Simplify RendererProxy and RendererImplementation to Fabric-only~~ Simplify RendererProxy and RendererImplementation to Fabric-only (#56556) Apr 22, 2026

rubennorte force-pushed the export-D101353113 branch from accdcfb to 0820958 Compare April 22, 2026 12:11

rubennorte force-pushed the export-D101353113 branch from 0820958 to 2dd046e Compare April 22, 2026 12:13

rubennorte force-pushed the export-D101353113 branch from 2dd046e to 04db788 Compare April 22, 2026 12:15

rubennorte force-pushed the export-D101353113 branch from 04db788 to d8a53a4 Compare April 22, 2026 12:26

rubennorte force-pushed the export-D101353113 branch from d8a53a4 to a431905 Compare April 22, 2026 12:50

rubennorte force-pushed the export-D101353113 branch 2 times, most recently from 2757e47 to 2b2e4c7 Compare April 22, 2026 15:53

rubennorte force-pushed the export-D101353113 branch from 2b2e4c7 to 5e476b7 Compare April 22, 2026 15:53

rubennorte force-pushed the export-D101353113 branch from 5e476b7 to 66e5bad Compare April 22, 2026 15:57

rubennorte force-pushed the export-D101353113 branch from 66e5bad to f62c3e8 Compare April 22, 2026 16:27

rubennorte force-pushed the export-D101353113 branch from f62c3e8 to 4817807 Compare April 22, 2026 16:30

rubennorte force-pushed the export-D101353113 branch from 4817807 to 53ab47e Compare April 23, 2026 10:14

rubennorte force-pushed the export-D101353113 branch from 53ab47e to ddac353 Compare April 23, 2026 10:18

meta-codesync Bot closed this in 1a623a8 Apr 23, 2026

facebook-github-tools Bot added the Merged This PR has been merged. label Apr 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify RendererProxy and RendererImplementation to Fabric-only (#56556)#56556

Simplify RendererProxy and RendererImplementation to Fabric-only (#56556)#56556
rubennorte wants to merge 2 commits into
facebook:mainfrom
rubennorte:export-D101353113

rubennorte commented Apr 22, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

meta-codesync Bot commented Apr 22, 2026

Uh oh!

meta-codesync Bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

rubennorte commented Apr 22, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meta-codesync Bot commented Apr 22, 2026

Uh oh!

meta-codesync Bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

rubennorte commented Apr 22, 2026 •

edited by meta-codesync Bot

Loading