Skip to content

Commit 53be338

Browse files
committed
[compiler] Disambiguate between void, implicit, and explicit returns (#33989)
Adds a new property to ReturnTerminals to disambiguate whether it was explicit, implicit (arrow function expressions), or void (where it was omitted). I will use this property in the next PR adding a new validation pass. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33989). * #34022 * #34002 * #34001 * #33990 * __->__ #33989 DiffTrain build for [5dd622e](5dd622e)
1 parent 6d509fd commit 53be338

26 files changed

+103
-91
lines changed

compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-19baee81-20250725
1+
19.2.0-native-fb-5dd622ea-20250728

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9b270a16206ab7973619428561e2048c>>
10+
* @generated SignedSource<<372ad50ac9597572b2350a6558a3d195>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-19baee81-20250725";
407+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";
408408
})();

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d951c93a38f8e641db74db4320e12d45>>
10+
* @generated SignedSource<<6f7abd1f44c476c394df3bf31a349203>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-19baee81-20250725";
206+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d951c93a38f8e641db74db4320e12d45>>
10+
* @generated SignedSource<<6f7abd1f44c476c394df3bf31a349203>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-19baee81-20250725";
206+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<071efcef088b318f0a3b3fbf6b2ce842>>
10+
* @generated SignedSource<<c865b89aea01dbb44a9912df49dff55b>>
1111
*/
1212

1313
/*
@@ -29012,11 +29012,11 @@ __DEV__ &&
2901229012
};
2901329013
(function () {
2901429014
var isomorphicReactPackageVersion = React.version;
29015-
if ("19.2.0-native-fb-19baee81-20250725" !== isomorphicReactPackageVersion)
29015+
if ("19.2.0-native-fb-5dd622ea-20250728" !== isomorphicReactPackageVersion)
2901629016
throw Error(
2901729017
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2901829018
(isomorphicReactPackageVersion +
29019-
"\n - react-dom: 19.2.0-native-fb-19baee81-20250725\nLearn more: https://react.dev/warnings/version-mismatch")
29019+
"\n - react-dom: 19.2.0-native-fb-5dd622ea-20250728\nLearn more: https://react.dev/warnings/version-mismatch")
2902029020
);
2902129021
})();
2902229022
("function" === typeof Map &&
@@ -29053,10 +29053,10 @@ __DEV__ &&
2905329053
!(function () {
2905429054
var internals = {
2905529055
bundleType: 1,
29056-
version: "19.2.0-native-fb-19baee81-20250725",
29056+
version: "19.2.0-native-fb-5dd622ea-20250728",
2905729057
rendererPackageName: "react-dom",
2905829058
currentDispatcherRef: ReactSharedInternals,
29059-
reconcilerVersion: "19.2.0-native-fb-19baee81-20250725"
29059+
reconcilerVersion: "19.2.0-native-fb-5dd622ea-20250728"
2906029060
};
2906129061
internals.overrideHookState = overrideHookState;
2906229062
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29194,5 +29194,5 @@ __DEV__ &&
2919429194
listenToAllSupportedEvents(container);
2919529195
return new ReactDOMHydrationRoot(initialChildren);
2919629196
};
29197-
exports.version = "19.2.0-native-fb-19baee81-20250725";
29197+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";
2919829198
})();

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ca51ad8d30a4041fadd552b6d0ad0512>>
10+
* @generated SignedSource<<57a7d511de4d084f87aed2df0f15f35d>>
1111
*/
1212

1313
/*
@@ -17123,14 +17123,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1712317123
};
1712417124
var isomorphicReactPackageVersion$jscomp$inline_2004 = React.version;
1712517125
if (
17126-
"19.2.0-native-fb-19baee81-20250725" !==
17126+
"19.2.0-native-fb-5dd622ea-20250728" !==
1712717127
isomorphicReactPackageVersion$jscomp$inline_2004
1712817128
)
1712917129
throw Error(
1713017130
formatProdErrorMessage(
1713117131
527,
1713217132
isomorphicReactPackageVersion$jscomp$inline_2004,
17133-
"19.2.0-native-fb-19baee81-20250725"
17133+
"19.2.0-native-fb-5dd622ea-20250728"
1713417134
)
1713517135
);
1713617136
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17152,10 +17152,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1715217152
};
1715317153
var internals$jscomp$inline_2523 = {
1715417154
bundleType: 0,
17155-
version: "19.2.0-native-fb-19baee81-20250725",
17155+
version: "19.2.0-native-fb-5dd622ea-20250728",
1715617156
rendererPackageName: "react-dom",
1715717157
currentDispatcherRef: ReactSharedInternals,
17158-
reconcilerVersion: "19.2.0-native-fb-19baee81-20250725"
17158+
reconcilerVersion: "19.2.0-native-fb-5dd622ea-20250728"
1715917159
};
1716017160
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1716117161
var hook$jscomp$inline_2524 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17253,4 +17253,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1725317253
listenToAllSupportedEvents(container);
1725417254
return new ReactDOMHydrationRoot(initialChildren);
1725517255
};
17256-
exports.version = "19.2.0-native-fb-19baee81-20250725";
17256+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<310d170216c04a7e942b2b78e12a6a7c>>
10+
* @generated SignedSource<<c2b7e3fd173636aa78869d11a393c72b>>
1111
*/
1212

1313
/*
@@ -19081,14 +19081,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1908119081
};
1908219082
var isomorphicReactPackageVersion$jscomp$inline_2244 = React.version;
1908319083
if (
19084-
"19.2.0-native-fb-19baee81-20250725" !==
19084+
"19.2.0-native-fb-5dd622ea-20250728" !==
1908519085
isomorphicReactPackageVersion$jscomp$inline_2244
1908619086
)
1908719087
throw Error(
1908819088
formatProdErrorMessage(
1908919089
527,
1909019090
isomorphicReactPackageVersion$jscomp$inline_2244,
19091-
"19.2.0-native-fb-19baee81-20250725"
19091+
"19.2.0-native-fb-5dd622ea-20250728"
1909219092
)
1909319093
);
1909419094
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19110,10 +19110,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1911019110
};
1911119111
var internals$jscomp$inline_2251 = {
1911219112
bundleType: 0,
19113-
version: "19.2.0-native-fb-19baee81-20250725",
19113+
version: "19.2.0-native-fb-5dd622ea-20250728",
1911419114
rendererPackageName: "react-dom",
1911519115
currentDispatcherRef: ReactSharedInternals,
19116-
reconcilerVersion: "19.2.0-native-fb-19baee81-20250725",
19116+
reconcilerVersion: "19.2.0-native-fb-5dd622ea-20250728",
1911719117
getLaneLabelMap: function () {
1911819118
for (
1911919119
var map = new Map(), lane = 1, index$319 = 0;
@@ -19226,4 +19226,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1922619226
listenToAllSupportedEvents(container);
1922719227
return new ReactDOMHydrationRoot(initialChildren);
1922819228
};
19229-
exports.version = "19.2.0-native-fb-19baee81-20250725";
19229+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2be065e8d604917db31da29e33c71a6e>>
10+
* @generated SignedSource<<e6767d7d109d1bf0b28f6441ebe5d654>>
1111
*/
1212

1313
/*
@@ -29068,11 +29068,11 @@ __DEV__ &&
2906829068
};
2906929069
(function () {
2907029070
var isomorphicReactPackageVersion = React.version;
29071-
if ("19.2.0-native-fb-19baee81-20250725" !== isomorphicReactPackageVersion)
29071+
if ("19.2.0-native-fb-5dd622ea-20250728" !== isomorphicReactPackageVersion)
2907229072
throw Error(
2907329073
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2907429074
(isomorphicReactPackageVersion +
29075-
"\n - react-dom: 19.2.0-native-fb-19baee81-20250725\nLearn more: https://react.dev/warnings/version-mismatch")
29075+
"\n - react-dom: 19.2.0-native-fb-5dd622ea-20250728\nLearn more: https://react.dev/warnings/version-mismatch")
2907629076
);
2907729077
})();
2907829078
("function" === typeof Map &&
@@ -29109,10 +29109,10 @@ __DEV__ &&
2910929109
!(function () {
2911029110
var internals = {
2911129111
bundleType: 1,
29112-
version: "19.2.0-native-fb-19baee81-20250725",
29112+
version: "19.2.0-native-fb-5dd622ea-20250728",
2911329113
rendererPackageName: "react-dom",
2911429114
currentDispatcherRef: ReactSharedInternals,
29115-
reconcilerVersion: "19.2.0-native-fb-19baee81-20250725"
29115+
reconcilerVersion: "19.2.0-native-fb-5dd622ea-20250728"
2911629116
};
2911729117
internals.overrideHookState = overrideHookState;
2911829118
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29566,7 +29566,7 @@ __DEV__ &&
2956629566
exports.useFormStatus = function () {
2956729567
return resolveDispatcher().useHostTransitionStatus();
2956829568
};
29569-
exports.version = "19.2.0-native-fb-19baee81-20250725";
29569+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";
2957029570
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2957129571
"function" ===
2957229572
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c01c0236135eae0760887c74c072580e>>
10+
* @generated SignedSource<<f0e2d0bee750206a8cec7e4c27dfeb19>>
1111
*/
1212

1313
/*
@@ -17134,14 +17134,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1713417134
};
1713517135
var isomorphicReactPackageVersion$jscomp$inline_2005 = React.version;
1713617136
if (
17137-
"19.2.0-native-fb-19baee81-20250725" !==
17137+
"19.2.0-native-fb-5dd622ea-20250728" !==
1713817138
isomorphicReactPackageVersion$jscomp$inline_2005
1713917139
)
1714017140
throw Error(
1714117141
formatProdErrorMessage(
1714217142
527,
1714317143
isomorphicReactPackageVersion$jscomp$inline_2005,
17144-
"19.2.0-native-fb-19baee81-20250725"
17144+
"19.2.0-native-fb-5dd622ea-20250728"
1714517145
)
1714617146
);
1714717147
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17163,10 +17163,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1716317163
};
1716417164
var internals$jscomp$inline_2526 = {
1716517165
bundleType: 0,
17166-
version: "19.2.0-native-fb-19baee81-20250725",
17166+
version: "19.2.0-native-fb-5dd622ea-20250728",
1716717167
rendererPackageName: "react-dom",
1716817168
currentDispatcherRef: ReactSharedInternals,
17169-
reconcilerVersion: "19.2.0-native-fb-19baee81-20250725"
17169+
reconcilerVersion: "19.2.0-native-fb-5dd622ea-20250728"
1717017170
};
1717117171
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1717217172
var hook$jscomp$inline_2527 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17417,4 +17417,4 @@ exports.useFormState = function (action, initialState, permalink) {
1741717417
exports.useFormStatus = function () {
1741817418
return ReactSharedInternals.H.useHostTransitionStatus();
1741917419
};
17420-
exports.version = "19.2.0-native-fb-19baee81-20250725";
17420+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2c7cd821b9a543e926497c6369f739ba>>
10+
* @generated SignedSource<<02aea01de73ed361f83e54bf0c7193f7>>
1111
*/
1212

1313
/*
@@ -19096,14 +19096,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1909619096
};
1909719097
var isomorphicReactPackageVersion$jscomp$inline_2245 = React.version;
1909819098
if (
19099-
"19.2.0-native-fb-19baee81-20250725" !==
19099+
"19.2.0-native-fb-5dd622ea-20250728" !==
1910019100
isomorphicReactPackageVersion$jscomp$inline_2245
1910119101
)
1910219102
throw Error(
1910319103
formatProdErrorMessage(
1910419104
527,
1910519105
isomorphicReactPackageVersion$jscomp$inline_2245,
19106-
"19.2.0-native-fb-19baee81-20250725"
19106+
"19.2.0-native-fb-5dd622ea-20250728"
1910719107
)
1910819108
);
1910919109
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19125,10 +19125,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1912519125
};
1912619126
var internals$jscomp$inline_2252 = {
1912719127
bundleType: 0,
19128-
version: "19.2.0-native-fb-19baee81-20250725",
19128+
version: "19.2.0-native-fb-5dd622ea-20250728",
1912919129
rendererPackageName: "react-dom",
1913019130
currentDispatcherRef: ReactSharedInternals,
19131-
reconcilerVersion: "19.2.0-native-fb-19baee81-20250725",
19131+
reconcilerVersion: "19.2.0-native-fb-5dd622ea-20250728",
1913219132
getLaneLabelMap: function () {
1913319133
for (
1913419134
var map = new Map(), lane = 1, index$319 = 0;
@@ -19394,7 +19394,7 @@ exports.useFormState = function (action, initialState, permalink) {
1939419394
exports.useFormStatus = function () {
1939519395
return ReactSharedInternals.H.useHostTransitionStatus();
1939619396
};
19397-
exports.version = "19.2.0-native-fb-19baee81-20250725";
19397+
exports.version = "19.2.0-native-fb-5dd622ea-20250728";
1939819398
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1939919399
"function" ===
1940019400
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)