scsc: depend on srclient only on linux

Summary:
Remove `srclient` as a depedency on windows and macos.  It's not available there.

This means we'll need to find another way to do D71031796 on these platforms, but first let's unbreak the build.

Reviewed By: gustavoavena

Differential Revision: D71893243

fbshipit-source-id: 59dd0cee453c107a95146d17b0b72c521b3a0ec7

Author: markbt

eden/mononoke/scs/client/BUCK

@@ -12,6 +12,7 @@ rust_binary(
             "linux",
             [
                 "//common/rust/build_info:build_info",
+                "//common/rust/thrift/srclient:srclient",
             ],
         ),
         (
@@ -52,7 +53,6 @@ rust_binary(
         "//common/rust/shed/fbinit:fbinit",
         "//common/rust/shed/fbinit:fbinit-tokio",
         "//common/rust/shed/hostcaps:hostcaps",
-        "//common/rust/thrift/srclient:srclient",
         "//eden/mononoke/cmdlib/base_app:base_app",
         "//eden/mononoke/scs/if:source_control-rust",
         "//eden/mononoke/scs/if:source_control-rust-clients",

eden/mononoke/scs/client/src/errors.rs

@@ -42,7 +42,6 @@ use source_control_clients::errors::RepoResolveCommitPrefixError;
 use source_control_clients::errors::RepoStackGitBundleStoreError;
 use source_control_clients::errors::RepoUpdateSubmoduleExpansionError;
 use source_control_clients::errors::TreeListError;
-use srclient::ErrorReason;
 
 pub(crate) trait SelectionErrorExt {
     fn handle_selection_error(self, repo: &thrift::RepoSpecifier) -> Error;
@@ -53,9 +52,10 @@ macro_rules! impl_handle_selection_error {
         impl SelectionErrorExt for $type {
             fn handle_selection_error(self, repo: &thrift::RepoSpecifier) -> Error {
                 if let $type::ThriftError(ref err) = self {
+                    #[cfg(not(any(target_os = "macos", target_os = "windows")))]
                     if let Some(err) = err.downcast_ref::<srclient::TServiceRouterException>() {
                         if err.is_selection_error()
-                            && err.error_reason() == ErrorReason::SELECTION_NONEXISTENT_DOMAIN
+                            && err.error_reason() == srclient::ErrorReason::SELECTION_NONEXISTENT_DOMAIN
                         {
                             if let Some(possible_repo_name) = repo.name.strip_suffix(".git") {
                                 return anyhow!("repo does not exist: {}. Try removing the .git suffix (i.e. -R {})", repo.name, possible_repo_name);