fix clippy lints & buck2 OSS CI errors

Summary:
Fix existing 1.90.0 and new 1.91.1 clippy lints via:
```
buck2 run fbcode//common/rust/tools/rustfix2:rustfix -- --clippy --target fbcode//common/rust/... --target fbcode//buck2/allocative/... --target fbcode//buck2/app/... --target fbcode//buck2/buck2_tpx_cli/... --target fbcode//buck2/dice/... --target fbcode//buck2/dice_replay/... --target fbcode//buck2/facebook/... --target fbcode//buck2/gazebo/... --target fbcode//buck2/host_sharing/... --target fbcode//buck2/integrations/... --target fbcode//buck2/remote_execution/... --target fbcode//buck2/shed/... --target fbcode//buck2/starlark-rust/... --target fbcode//buck2/superconsole/... --target fbcode//remote_execution/... --target fbcode//target_determinator/...
```

plus OSS errors from `fbcode/buck2/scripts/ci.sh`

Reviewed By: dtolnay

Differential Revision: D87088632

fbshipit-source-id: 956943c547bb2ebe5aa8b031d741e9467233352e

Author: diliop

allocative/allocative/src/flamegraph.rs

@@ -86,7 +86,7 @@ impl FlameGraph {
 
     /// Write flamegraph in format suitable for [`flamegraph.pl`] or [inferno].
     ///
-    /// [flamegraph.pl]: https://github.com/brendangregg/FlameGraph
+    /// [`flamegraph.pl`]: https://github.com/brendangregg/FlameGraph
     /// [inferno]: https://github.com/jonhoo/inferno
     pub fn write(&self) -> String {
         let mut r = String::new();

starlark_map/src/vec2/iter.rs

@@ -115,8 +115,14 @@ impl<A, B> Drop for IntoIter<A, B> {
     fn drop(&mut self) {
         unsafe {
             let rem = self.len();
-            ptr::drop_in_place(slice::from_raw_parts_mut(self.aaa_begin.as_ptr(), rem));
-            ptr::drop_in_place(slice::from_raw_parts_mut(self.bbb_begin.as_ptr(), rem));
+            ptr::drop_in_place(std::ptr::slice_from_raw_parts_mut(
+                self.aaa_begin.as_ptr(),
+                rem,
+            ));
+            ptr::drop_in_place(std::ptr::slice_from_raw_parts_mut(
+                self.bbb_begin.as_ptr(),
+                rem,
+            ));
             Vec2::<A, B>::dealloc_impl(self.bbb_ptr, self.cap);
         }
     }