This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Implement a Windows fallback #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 24, 2016 19:55
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
ghost
added
the
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I had to increment the version of Go as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Win fall back version of Serve function to fix #15. This change will make the package buildable on Windows, though graceful restarts / shutdowns will not be supported on it.
Changelog
gracehttp/http.goandhttp_test.goare moved as-is to thenix.goandnix_test.go.+build !windowstags are added to both and to thetestbin_test.go.pprintAddrand modification of(*app).listen(...)are moved from from thenix.goto thehttp.gowhere they can be reused between *nix and fallback versions of serve.serveFallbackis implemented in thehttp.goand covered by tests (http_test.go). It doesn't have a+build windowstag to make testing of the function on other platforms possible.win.gowith+build windowstag andServefunction (wrapper around theserveFallback) are added to be used on Windows.gracedemo/gracehttp.Servecall is wrapped bylog.Fatalto show the errors if any occur.If this is not the approach you'd like to take, feel free to close the PR.