Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for generating ULID #2648

Closed
matthewmayer opened this issue Feb 8, 2024 · 9 comments · Fixed by #2524
Closed

Add support for generating ULID #2648

matthewmayer opened this issue Feb 8, 2024 · 9 comments · Fixed by #2524
Assignees
@brunocleite
Labels
c: feature Request for new feature m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v9.x

Comments

@matthewmayer
Copy link
Contributor

Clear and concise description of the problem

There is another type of unique identifier other than UUID that is called ULID Universally Unique Lexicographically Sortable Identifier.
This type of identifier has the benefit of maintaining a sortable order and is useful as primary keys on databases (mainly NoSQL) to get free date-time sorting out of the box. More information here

ULID is a 26 characters string which the first 10 characters are the timestamp as millis from the epoch and the other 16 are the randomness.
The allowed characters are from Crockford's Base32 which excludes letters I, L, and O to avoid confusion with digits.

Suggested solution

ulid(): string {
    return (
      this.fromCharacters('012', 1) +
      this.fromCharacters('0123456789ABCDEFGHJKMNPQRSTVWXYZ', 25)
    );
  }

On the code excerpt above it is using the first character as [012] because that would already generate dates up to year 5314 which is more than enough. To confirm this behavior you can go here and try using 2ZZZZZZZZZWZYF0EJ600G2SZHA as an ULID.

Alternative

Allow it to use a refDate() like the methods in faker.date?

Additional context

Originally proposed by brunocleite at #2524 (comment)

Creating an issue here to allow it to collect upvotes, and discuss possible implementation strategies.
@matthewmayer matthewmayer added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Feb 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@matthewmayer matthewmayer mentioned this issue Feb 8, 2024
Merged
@matthewmayer matthewmayer linked a pull request Feb 8, 2024 that will close this issue
feat(string): adds support for generating ULID #2524
Merged
@matthewmayer
Copy link
Contributor Author

i would tend to agree with @Shinigami92 that, given that one of the key points of ULID is that it embeds a date, having more control over the range of dates embedded in the ULID would be useful. Either you pass it a specific date and it just adds the random part, or you can pass a range of dates and it creates within that range?

@ST-DDT
Copy link
Member

ST-DDT commented Feb 8, 2024

The question is, is the timestamp relevant for our users?
If it is and they already use ulids, then they could generate a date and pass it to their ulid library.
IMO we should start with random ulids, if users need time based ones, then they should open a new issue.
Note we also don't have a time based uuid.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent m: string Something is referring to the string module labels Feb 8, 2024
@ST-DDT ST-DDT added this to the vFuture milestone Feb 8, 2024
@Shinigami92
Copy link
Member

Note we also don't have a time based uuid.

That's because we only provide UUID v4 right now.
Until now there was never a feature request to support timed UUIDs like v1, v2, v6 and v7.

@ST-DDT
Copy link
Member

ST-DDT commented Feb 9, 2024

Until now there was never a feature request to support timed UUIDs like v1, v2, v6 and v7.

IMO random ulids and time based ulids are two different feature requests.
Yes, you could implement them together, but if there is no real interest in time based ones, I don't see a point adding them.
If there was an interest in time based stuff, I would have expected a feature request for time based uuids as well, but so far there aren't any.

@ST-DDT
Copy link
Member

ST-DDT commented Feb 9, 2024

Do you have a need for time based ulids or are you asking for them just because the are in the standard?

@matthewmayer
Copy link
Contributor Author

I think just wait until we have a few more upvotes on this. We don't have enough information on how this would be used to make a sensible decision yet.

@ST-DDT ST-DDT removed the s: pending triage Pending Triage label Feb 24, 2024
brunocleite added a commit to brunocleite/fork--faker that referenced this issue Mar 18, 2024
@brunocleite
fix(string): update ulid values (faker-js#2648)
9ba1bbe
@ST-DDT
Copy link
Member

ST-DDT commented Jul 4, 2024

Team Decision

This has gathered enough interest.
Additionally, we consider it useful for inclusion in faker v9.x.

We will review brunocleite's PR in the near future:

PS: @brunocleite, could you please leave a comment here, so we can assign this issue to you?

@ST-DDT ST-DDT modified the milestones: vFuture, v9.x Jul 4, 2024
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: waiting for user interest Waiting for more users interested in this feature labels Jul 4, 2024
@brunocleite
Copy link
Contributor

brunocleite commented Jul 4, 2024 •
edited
Loading

@ST-DDT Yes, you can assign it to me, please. I have updated the PR with a more elaborated solution including support for refDate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunocleite brunocleite

Labels
c: feature Request for new feature m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v9.x
Development

Successfully merging a pull request may close this issue.

feat(string): adds support for generating ULID brunocleite/fork--faker
4 participants
@brunocleite @matthewmayer @ST-DDT @Shinigami92