Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve JavaDoc and Code Comments #212

Open
psxjoy opened this issue Jan 30, 2025 · 4 comments
Open

[Enhancement] Improve JavaDoc and Code Comments #212

psxjoy opened this issue Jan 30, 2025 · 4 comments
Labels
good first issue Good for newcomers

Comments

@psxjoy
Copy link
Member

psxjoy commented Jan 30, 2025

Descript

Some functions in Fastexcel currently lack proper JavaDoc or inline comments, which may make them more difficult for newcomers to understand.

Goal:

Add well-structured JavaDoc and comments to core functions to enhance code readability and usability.

@fu-shenqi
Copy link

fu-shenqi commented Feb 26, 2025

I want to try it ,as it will also allow me to gain a deeper understanding of FastExcel. I look forward to having a more in-depth conversation about this questions with you.

@psxjoy
Copy link
Member Author

psxjoy commented Feb 26, 2025

I want to try it ,as it will also allow me to gain a deeper understanding of FastExcel. I look forward to having a more in-depth conversation about this questions with you.

This represents an ongoing, long-term initiative aimed at eradicating typos and enhancing the project's readability.
IMO, initiating this effort by correcting typos or annotating certain functions serves as an excellent starting point.

Every PR that aids in enhancing the project deserves encouragement :)

@psxjoy psxjoy pinned this issue Feb 26, 2025
@fu-shenqi
Copy link

May I ask if there is any specific function list that requires writing a comment document? I didn't know where to start when it came to participating in an open source project for the first time.

@psxjoy
Copy link
Member Author

psxjoy commented Feb 27, 2025

May I ask if there is any specific function list that requires writing a comment document? I didn't know where to start when it came to participating in an open source project for the first time.

IMO, annotating test cases is an excellent approach for those new to the project.
There's no need to worry excessively about making mistakes or submitting PRs that may not be perfect;
we appreciate all efforts directed towards enhancing the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants