Skip to content

Commit be5316c

Browse files
committed
include version in archive tarball filenames?
1 parent 80d263d commit be5316c

3 files changed

Lines changed: 21 additions & 15 deletions

File tree

.github/workflows/release.yml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,28 +31,31 @@ jobs:
3131

3232
- name: Build docs
3333
uses: mattnotmitt/doxygen-action@v1.9.5
34-
34+
35+
- name: Set env
36+
run: echo "ARCHIVE_FILENAME_PREFIX=fastly-compute-sdk-cpp-${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
37+
3538
- name: Archive core dist
36-
run: tar cvf fastly-compute-sdk-cpp.tar -C target/release/dist fastly libfastly.a
39+
run: tar cvf ${{ env.ARCHIVE_FILENAME_PREFIX }}.tar -C target/release/dist fastly libfastly.a
3740

3841
- name: Archive quickstart dist
39-
run: tar cvf fastly-compute-sdk-cpp-quickstart.tar -C target/release/dist fastly libfastly.a
42+
run: tar cvf ${{ env.ARCHIVE_FILENAME_PREFIX }}-quickstart.tar -C target/release/dist fastly libfastly.a
4043

4144
- name: Add docs and license to quickstart dist
42-
run: tar rvf fastly-compute-sdk-cpp-quickstart.tar docs LICENSE
45+
run: tar rvf ${{ env.ARCHIVE_FILENAME_PREFIX }}-quickstart.tar docs LICENSE
4346

4447
- name: Add quickstart files to quickstart dist
45-
run: tar rvf fastly-compute-sdk-cpp-quickstart.tar -C quickstart CMakeLists.txt fastly.toml main.cpp README.md
48+
run: tar rvf ${{ env.ARCHIVE_FILENAME_PREFIX }}-quickstart.tar -C quickstart CMakeLists.txt fastly.toml main.cpp README.md
4649

4750
- name: Gzip core dist
48-
run: gzip fastly-compute-sdk-cpp.tar
51+
run: gzip ${{ env.ARCHIVE_FILENAME_PREFIX }}.tar
4952

5053
- name: Gzip quickstart dist
51-
run: gzip fastly-compute-sdk-cpp-quickstart.tar
54+
run: gzip ${{ env.ARCHIVE_FILENAME_PREFIX }}-quickstart.tar
5255

5356
- uses: ncipollo/release-action@v1
5457
with:
55-
artifacts: fastly-compute-sdk-cpp*.tar.gz
58+
artifacts: "${{ env.ARCHIVE_FILENAME_PREFIX }}*.tar.gz"
5659
artifactErrorsFailBuild: true
5760
artifactContentType: "application/gzip"
5861
generateReleaseNotes: true

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
This SDK is lets you use Fastly Compute platform directly with C++, using a
44
C++-native API with all the usual facilities of modern C++. In case you got to
55
this page from elsewhere, the full documentation is available online at [this
6-
link](https://cuddly-adventure-lrw9z3m.pages.github.io/index.html).
6+
link](https://cuddly-adventure-lrw9z3m.pages.github.io).
77

88
#### Examples
99

@@ -20,7 +20,7 @@ To use the SDK from the prebuilt static library, all you need is:
2020
#### Quickstart
2121

2222
The fastest way to get started with the SDK is to fetch
23-
`fastly-compute-sdk-cpp-quickstart.tar.gz` from the [latest GitHub Release's
23+
`fastly-compute-sdk-cpp-quickstart-vX.Y.Z.tar.gz` from the [latest GitHub Release's
2424
assets list](https://github.com/fastly/compute-sdk-cpp/releases/latest). This
2525
tarball includes a full prebuilt version of the library, its headers, a copy of
2626
the full reference docs, and a set of quickstart files with a preconfigured,
@@ -29,7 +29,7 @@ CMake-based project.
2929
#### Just the SDK
3030

3131
If you only need the latest version of the library, fetch
32-
`fastly-compute-sdk-cpp-quickstart.tar.gz` from the [latest GitHub Release's
32+
`fastly-compute-sdk-cpp-vX.Y.Z-quickstart.tar.gz` from the [latest GitHub Release's
3333
assets list](https://github.com/fastly/compute-sdk-cpp/releases/latest) and
3434
place it somewhere accessible to your preferred build system.
3535

quickstart/README.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@ curl -d "hello, world!" http://127.0.0.1:7676/
4848

4949
## Documentation
5050

51-
The release tarball includes the HTML reference docs in `docs/html/index.html`,
52-
which you can open locally. If you've configured your editor properly, you may
53-
also be able to hover over Fastly SDK symbols to see their documentation
54-
in-place.
51+
Online documentation can be accessed
52+
[here](https://cuddly-adventure-lrw9z3m.pages.github.io/).
53+
54+
The quickstart tarball also includes the HTML reference docs in
55+
`docs/index.html`, which you can open locally. If you've configured your editor
56+
properly, you may also be able to hover over Fastly SDK symbols to see their
57+
documentation in-place.

0 commit comments

Comments
 (0)