Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose proxy information as prometheus metric #4044

Open
1 of 11 tasks
RobKenis opened this issue Mar 6, 2024 · 1 comment
Open
1 of 11 tasks

[Feature Request] Expose proxy information as prometheus metric #4044

RobKenis opened this issue Mar 6, 2024 · 1 comment
Labels

Comments

@RobKenis
Copy link
Contributor

RobKenis commented Mar 6, 2024

Describe the feature request

Add a prometheus metric frp_server_proxy_info{name, type, client_version} with information that is also exposed in the dashboard. This way I can include the client version in the same Grafana dashboard as my other FRP statistics.

Describe alternatives you've considered

Can I create a custom plugin to expose this information?

Affected area

  • Docs
  • Installation
  • Performance and Scalability
  • Security
  • User Experience
  • Test and Release
  • Developer Infrastructure
  • Client Plugin
  • Server Plugin
  • Extensions
  • Others
@fatedier
Copy link
Owner

fatedier commented Mar 7, 2024

The current implementation is not very elegant. The client_version should not actually be the metadata of the proxy. There should be a separate client/host object, and the proxy should be associated with this object.

We need to rethink the best implementation method here. We did not previously expose the client dimension object to the user, so this change may not be very simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants