Error when using $and query

[ericuldall]

I have the following service call in a hook:

app.service('my-service').patch(
            null,
            { public: false },
            {
                query: {
                    $and: [
                        { userId: user._id },
                        { lists: id },
                        { lists: { $nin: publicLists } }
                    ]
                },
                user
            }
        )

I'm getting the following set of errors:

error: Data: [
  {
    instancePath: '/$and/1',
    schemaPath: '#/properties/%24and/items/anyOf/0/additionalProperties',
    keyword: 'additionalProperties',
    params: { additionalProperty: 'lists' },
    message: 'must NOT have additional properties'
  },
  {
    instancePath: '/$and/1',
    schemaPath: '#/properties/%24and/items/anyOf/1/required',
    keyword: 'required',
    params: { missingProperty: '$or' },
    message: "must have required property '$or'"
  },
  {
    instancePath: '/$and/1',
    schemaPath: '#/properties/%24and/items/anyOf',
    keyword: 'anyOf',
    params: {},
    message: 'must match a schema in anyOf'
  }
]

Am I missing something obvious here, @daffl ? I don't recall having issues using $and in the past. Any help is appreciated.

[ericuldall]

Using feathers v5 w/ typebox

[daffl]

Do you have latest v5 (currently 5.0.11) installed?

[ericuldall]

Yes, just updated to the latest and i'm getting that error.

[ericuldall]

Are you able to confirm if there's any issue with my implementation @daffl ?

[ericuldall]

I'm not sure if there's something I'm missing but in order to make my query work I had to add the following:

const listTypeFixes = Type.Optional(Type.Union([
  ObjectIdSchema(),
  Type.Array(ObjectIdSchema()),
  Type.Object({ $nin: Type.Array(ObjectIdSchema()) }),
]));
export const savedProductsQueryProperties = Type.Pick(savedProductsSchema, ['_id', '_shortId', 'userId', 'public', 'productId', 'createdAt', 'updatedAt'])
export const savedProductsQuerySchema = Type.Intersect(
  [
    querySyntax(savedProductsQueryProperties),
    // Add additional query properties here
    Type.Object({
      lists: listTypeFixes,
      $and: Type.Array(Type.Object({
        lists: listTypeFixes
      }))
    }, { additionalProperties: false })
  ],
  { additionalProperties: false }
)

This seems excessive to require in every case of a filter use. Is this just an issue with typebox implementation?

[daffl]

I'm not sure why this is happening since $and is definitely being added in the querySyntax helper in https://github.com/feathersjs/feathers/blob/dove/packages/typebox/src/index.ts#L176

[ericuldall]

Yes it's strange, and now i'm getting a similar issue with $in when implementing the dataloader