Skip to content

Commit 5b5cc0e

Browse files
authored
Merge pull request matplotlib#23355 from matplotlib/revert-23095-osx-tk-xfail
Revert "Try to unbreak CI by xfailing OSX Tk tests"
2 parents 540ab07 + ac1a4c5 commit 5b5cc0e

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

lib/matplotlib/tests/test_backend_tk.py

-4
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ def _isolated_tk_test(success_count, func=None):
3737
sys.platform == "linux" and not _c_internal_utils.display_is_valid(),
3838
reason="$DISPLAY and $WAYLAND_DISPLAY are unset"
3939
)
40-
@pytest.mark.xfail( # GitHub issue #23094
41-
sys.platform == 'darwin',
42-
reason="Tk version mismatch on OSX CI"
43-
)
4440
@functools.wraps(func)
4541
def test_func():
4642
# even if the package exists, may not actually be importable this can

lib/matplotlib/tests/test_backends_interactive.py

-10
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,6 @@ def _get_testable_interactive_backends():
5959
elif env["MPLBACKEND"].startswith('wx') and sys.platform == 'darwin':
6060
# ignore on OSX because that's currently broken (github #16849)
6161
marks.append(pytest.mark.xfail(reason='github #16849'))
62-
elif env["MPLBACKEND"] == "tkagg" and sys.platform == 'darwin':
63-
marks.append( # GitHub issue #23094
64-
pytest.mark.xfail(reason="Tk version mismatch on OSX CI"))
6562
envs.append(
6663
pytest.param(
6764
{**env, 'BACKEND_DEPS': ','.join(deps)},
@@ -236,9 +233,6 @@ def _test_thread_impl():
236233
reason='PyPy does not support Tkinter threading: '
237234
'https://foss.heptapod.net/pypy/pypy/-/issues/1929',
238235
strict=True))
239-
elif backend == "tkagg" and sys.platform == "darwin":
240-
param.marks.append( # GitHub issue #23094
241-
pytest.mark.xfail("Tk version mismatch on OSX CI"))
242236

243237

244238
@pytest.mark.parametrize("env", _thread_safe_backends)
@@ -516,10 +510,6 @@ def _test_number_of_draws_script():
516510
elif backend == "wx":
517511
param.marks.append(
518512
pytest.mark.skip("wx does not support blitting"))
519-
elif backend == "tkagg" and sys.platform == "darwin":
520-
param.marks.append( # GitHub issue #23094
521-
pytest.mark.xfail("Tk version mismatch on OSX CI")
522-
)
523513

524514

525515
@pytest.mark.parametrize("env", _blit_backends)

0 commit comments

Comments
 (0)