Skip to content

Commit 38e1459

Browse files
committed
refactor: update signal connection comments for clarity in MainWindow
1 parent a495731 commit 38e1459

1 file changed

Lines changed: 27 additions & 28 deletions

File tree

plaid/plaid.py

Lines changed: 27 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -392,45 +392,44 @@ def _init_dock_widget_settings(self):
392392
def _init_connections(self):
393393
"""Initialize the connections between the widgets. Called by self.__init__()."""
394394
# Connect the file tree signals to the appropriate slots
395-
self.file_tree.sigItemDoubleClicked.connect(self.load_file)
396-
self.file_tree.sigGroupDoubleClicked.connect(self.load_file)
397-
self.file_tree.sigItemRemoved.connect(self.remove_file)
398-
self.file_tree.sigI0DataRequested.connect(self.load_I0_data)
399-
self.file_tree.sigAuxiliaryDataRequested.connect(self.load_auxiliary_data)
395+
self.file_tree.sigItemDoubleClicked.connect(self.load_file) # --> str, obj
396+
self.file_tree.sigGroupDoubleClicked.connect(self.load_file) # --> list, list
397+
self.file_tree.sigItemRemoved.connect(self.remove_file) # --> str
398+
self.file_tree.sigI0DataRequested.connect(self.load_I0_data) # --> str
399+
self.file_tree.sigAuxiliaryDataRequested.connect(self.load_auxiliary_data) # --> str
400400
# Connect the CIF tree signals to the appropriate slots
401401
self.cif_tree.sigItemAdded.connect(self.add_reference) # --> str
402402
self.cif_tree.sigItemChecked.connect(self.toggle_reference) # --> int, bool
403403
self.cif_tree.sigItemDoubleClicked.connect(self.rescale_reference) # --> int, str
404404
self.cif_tree.sigItemRemoved.connect(self.remove_reference) # --> int
405405
self.cif_tree.sigItemReloadRequested.connect(self.reload_reference) # --> int
406406
# Connect the heatmap signals to the appropriate slots
407-
self.heatmap.sigHLineMoved.connect(self.hline_moved)
408-
self.heatmap.sigXRangeChanged.connect(self.pattern.set_xrange)
409-
self.heatmap.sigImageDoubleClicked.connect(self.add_pattern)
410-
self.heatmap.sigImageHovered.connect(self._update_status_bar)
411-
self.heatmap.sigHLineRemoved.connect(self.remove_pattern)
407+
self.heatmap.sigHLineMoved.connect(self.hline_moved) # --> int, int
408+
self.heatmap.sigXRangeChanged.connect(self.pattern.set_xrange) # --> object
409+
self.heatmap.sigImageDoubleClicked.connect(self.add_pattern) # --> object
410+
self.heatmap.sigImageHovered.connect(self._update_status_bar) # --> object
411+
self.heatmap.sigHLineRemoved.connect(self.remove_pattern) # --> int
412412
# Connect the pattern signals to the appropriate slots
413-
self.pattern.sigXRangeChanged.connect(self.heatmap.set_xrange)
414-
self.pattern.sigPatternHovered.connect(self.update_status_bar)
415-
self.pattern.sigLinearRegionChangedFinished.connect(self.set_diffraction_map)
416-
self.pattern.sigRequestQToggle.connect(self.toggle_q)
417-
self.pattern.sigRequestLockPattern.connect(self.handle_lock_pattern_request)
418-
self.pattern.sigRequestSubtractPattern.connect(self.set_active_pattern_as_background)
419-
self.pattern.sigRequestCorrelationMap.connect(self.show_correlation_map)
420-
self.pattern.sigRequestDiffractionMap.connect(lambda: self.show_diffraction_map())
421-
self.pattern.sigRequestExportAvg.connect(self.export_average_pattern)
422-
self.pattern.sigRequestExportCurrent.connect(self.export_pattern)
423-
self.pattern.sigRequestExportAll.connect(self.export_all_patterns)
424-
413+
self.pattern.sigXRangeChanged.connect(self.heatmap.set_xrange) # --> object
414+
self.pattern.sigPatternHovered.connect(self.update_status_bar) # --> object
415+
self.pattern.sigLinearRegionChangedFinished.connect(self.set_diffraction_map) # --> object
416+
self.pattern.sigRequestQToggle.connect(self.toggle_q) # --> ()
417+
self.pattern.sigRequestLockPattern.connect(self.handle_lock_pattern_request) # --> object
418+
self.pattern.sigRequestSubtractPattern.connect(self.set_active_pattern_as_background) # --> ()
419+
self.pattern.sigRequestCorrelationMap.connect(self.show_correlation_map) # --> ()
420+
self.pattern.sigRequestDiffractionMap.connect(lambda: self.show_diffraction_map()) # --> ()
421+
self.pattern.sigRequestExportAvg.connect(self.export_average_pattern) # --> ()
422+
self.pattern.sigRequestExportCurrent.connect(self.export_pattern) # --> ()
423+
self.pattern.sigRequestExportAll.connect(self.export_all_patterns) # --> ()
425424
# Connect the auxiliary plot signals to the appropriate slots
426-
self.auxiliary_plot.sigVLineMoved.connect(self.vline_moved)
427-
self.auxiliary_plot.sigAuxHovered.connect(self.update_status_bar_aux)
425+
self.auxiliary_plot.sigVLineMoved.connect(self.vline_moved) # --> int, int
426+
self.auxiliary_plot.sigAuxHovered.connect(self.update_status_bar_aux) # --> object
428427

429-
self.correlation_map_dock.visibilityChanged.connect(self.update_correlation_map)
430-
self.correlation_map.sigImageDoubleClicked.connect(self.correlation_map_double_clicked)
428+
self.correlation_map_dock.visibilityChanged.connect(self.update_correlation_map) # --> bool
429+
self.correlation_map.sigImageDoubleClicked.connect(self.correlation_map_double_clicked) # --> object
431430

432-
self.diffraction_map_dock.visibilityChanged.connect(self.update_diffraction_map)
433-
self.diffraction_map.sigImageDoubleClicked.connect(self.diffraction_map_double_clicked)
431+
self.diffraction_map_dock.visibilityChanged.connect(self.update_diffraction_map) # --> bool
432+
self.diffraction_map.sigImageDoubleClicked.connect(self.diffraction_map_double_clicked) # --> object
434433

435434
def _init_menu_bar(self):
436435
"""Initialize the menu bar with the necessary menus and actions. Called by self.__init__()."""

0 commit comments

Comments
 (0)