cleanup

Author: fglock

src/main/java/org/perlonjava/operators/Pack.java

@@ -56,11 +56,7 @@ public static RuntimeScalar pack(RuntimeList args) {
 
         // Track if 'U' was used in normal mode (not byte mode)
         boolean hasUnicodeInNormalMode = false;
-
-        // Stack to track byte order for nested groups
-        java.util.Stack<Character> groupEndianStack = new java.util.Stack<>();
-        groupEndianStack.push(' '); // Default: no specific endianness
-
+        
         for (int i = 0; i < template.length(); i++) {
             char format = template.charAt(i);
             System.err.println("DEBUG: main loop i=" + i + ", format='" + format + "' (code " + (int)format + ")");
@@ -902,25 +898,4 @@ private static int countValuesNeeded(String template) {
         return count;
     }
 
-    private static char findLastNumericFormat(String template) {
-        char lastNumeric = '\0';
-        for (int i = 0; i < template.length(); i++) {
-            char c = template.charAt(i);
-            if (isNumericFormat(c) || c == 'Z') {
-                lastNumeric = c;
-            } else if (c == '(') {
-                // Skip the group
-                int closePos = findMatchingParen(template, i);
-                if (closePos != -1) {
-                    // Check inside the group
-                    char groupNumeric = findLastNumericFormat(template.substring(i + 1, closePos));
-                    if (groupNumeric != '\0') {
-                        lastNumeric = groupNumeric;
-                    }
-                    i = closePos;
-                }
-            }
-        }
-        return lastNumeric;
-    }
 }

src/main/java/org/perlonjava/operators/pack/NullPadHandler.java

@@ -113,28 +113,10 @@ public static void writeHexString(ByteArrayOutputStream output, String str, int
      * Check if the format is an integer format that should reject Inf/NaN values
      */
     public static boolean isIntegerFormat(char format) {
-        switch (format) {
-            case 'c':
-            case 'C':
-            case 's':
-            case 'S':
-            case 'l':
-            case 'L':
-            case 'i':
-            case 'I':
-            case 'n':
-            case 'N':
-            case 'v':
-            case 'V':
-            case 'j':
-            case 'J':
-            case 'w':
-            case 'W':
-            case 'U':
-                return true;
-            default:
-                return false;
-        }
+        return switch (format) {
+            case 'c', 'C', 's', 'S', 'l', 'L', 'i', 'I', 'n', 'N', 'v', 'V', 'j', 'J', 'w', 'W', 'U' -> true;
+            default -> false;
+        };
     }
 
     /**
@@ -155,27 +137,6 @@ public static void writeBER(ByteArrayOutputStream output, long value) {
         }
     }
 
-    /**
-     * Validates the '/' format in pack/unpack templates.
-     */
-    public static char validateSlashFormat(String template, int position) {
-        if (position + 1 >= template.length()) {
-            throw new PerlCompilerException("Code missing after '/'");
-        }
-
-        char afterSlash = template.charAt(position + 1);
-
-        if (afterSlash == '*' || Character.isDigit(afterSlash)) {
-            throw new PerlCompilerException("'/' does not take a repeat count");
-        }
-
-        if (afterSlash != 'a' && afterSlash != 'A' && afterSlash != 'Z') {
-            throw new PerlCompilerException("'/' must be followed by a string type");
-        }
-
-        return afterSlash;
-    }
-
     /**
      * Writes a short integer to the output stream in little-endian order.
      *
@@ -330,13 +291,6 @@ public static void writeString(ByteArrayOutputStream output, String str, int cou
         }
     }
 
-    /**
-     * Overloaded writeString for backward compatibility
-     */
-    private static void writeString(ByteArrayOutputStream output, String str, int count, char format) {
-        writeString(output, str, count, format, false);
-    }
-
     /**
      * Writes a bit string to the output stream based on the specified format and count.
      *