Term::ReadKey WIP

Author: fglock

src/main/java/org/perlonjava/perlmodule/TermReadKey.java

@@ -77,17 +77,15 @@ public static void initialize() {
         saveOriginalTerminalSettings();
 
         // Register shutdown hook to restore terminal
-        Runtime.getRuntime().addShutdownHook(new Thread(() -> {
-            restoreTerminalMode();
-        }));
+        Runtime.getRuntime().addShutdownHook(new Thread(TermReadKey::restoreTerminalMode));
     }
 
     /**
      * Sets the terminal input mode.
      * ReadMode(mode, [filehandle])
      */
     public static RuntimeList readMode(RuntimeArray args, int ctx) {
-        if (args.size() == 0) {
+        if (args.isEmpty()) {
             return new RuntimeList(scalarUndef);
         }
 
@@ -115,7 +113,7 @@ public static RuntimeList readMode(RuntimeArray args, int ctx) {
     public static RuntimeList readKey(RuntimeArray args, int ctx) {
         int timeout = -1; // -1 means no timeout
 
-        if (args.size() > 0 && args.get(0).getDefinedBoolean()) {
+        if (!args.isEmpty() && args.get(0).getDefinedBoolean()) {
             timeout = args.get(0).getInt();
         }
 
@@ -140,7 +138,7 @@ public static RuntimeList readKey(RuntimeArray args, int ctx) {
     public static RuntimeList readLine(RuntimeArray args, int ctx) {
         int timeout = -1;
 
-        if (args.size() > 0 && args.get(0).getDefinedBoolean()) {
+        if (!args.isEmpty() && args.get(0).getDefinedBoolean()) {
             timeout = args.get(0).getInt();
         }
 
@@ -325,7 +323,7 @@ private static char readSingleCharWindows(int timeoutSeconds) throws IOException
             // Simple timeout implementation - not perfect but functional
             long startTime = System.currentTimeMillis();
             while (!reader.ready()) {
-                if (System.currentTimeMillis() - startTime > timeoutSeconds * 1000) {
+                if (System.currentTimeMillis() - startTime > timeoutSeconds * 1000L) {
                     return 0; // timeout
                 }
                 try {
@@ -347,7 +345,7 @@ private static char readSingleCharUnix(int timeoutSeconds) throws IOException {
         if (timeoutSeconds > 0) {
             long startTime = System.currentTimeMillis();
             while (in.available() == 0) {
-                if (System.currentTimeMillis() - startTime > timeoutSeconds * 1000) {
+                if (System.currentTimeMillis() - startTime > timeoutSeconds * 1000L) {
                     return 0; // timeout
                 }
                 try {
@@ -368,7 +366,7 @@ private static String readLineWithTimeout(int timeoutSeconds) throws IOException
         if (timeoutSeconds > 0) {
             long startTime = System.currentTimeMillis();
             while (!reader.ready()) {
-                if (System.currentTimeMillis() - startTime > timeoutSeconds * 1000) {
+                if (System.currentTimeMillis() - startTime > timeoutSeconds * 1000L) {
                     return null; // timeout
                 }
                 try {