ci: fix the test workflow setup

Author: galargh

.github/workflows/reusable-test.yml

@@ -30,7 +30,7 @@ jobs:
           VERY_EXPENSIVE_TESTS_RUN: ${{ inputs.run_very_expensive_tests }}
         run: |
           echo "test_group_execution_contexts<<EOF" >> $GITHUB_OUTPUT
-          go run ./cmd/ci/main.go --json --very-expensive-tests-run=$VERY_EXPENSIVE_TESTS_RUN list-test-group-execution-contexts | jq -r '.msg' | tee -a $GITHUB_OUTPUT
+          go run ./cmd/ci/main.go --json list-test-group-execution-contexts --very-expensive-tests-run=$VERY_EXPENSIVE_TESTS_RUN | jq -r '.msg' | tee -a $GITHUB_OUTPUT
           echo "EOF" >> $GITHUB_OUTPUT
   cache:
     name: Cache Dependencies
@@ -173,6 +173,7 @@ jobs:
         run: mktemp -d | xargs -0 -I{} echo "path={}" | tee -a $GITHUB_OUTPUT
       # TODO: Track coverage (used to be tracked for conformance)
       - name: Run tests
+        id: tests
         env:
           NAME: ${{ matrix.name }}
           LOTUS_SRC_DIR: ${{ github.workspace }}
@@ -183,19 +184,20 @@ jobs:
           LOTUS_RUN_VERY_EXPENSIVE_TESTS: ${{ inputs.run_very_expensive_tests && '1' || '0' }}
           FORMAT: ${{ fromJson(steps.group.outputs.metadata).format || 'standard-verbose' }}
           PACKAGES: ${{ join(fromJson(steps.group.outputs.metadata).packages, ' ') }}
+          TIMEOUT: ${{ inputs.run_very_expensive_tests && '60m' || '10m' }}
         run: |
           gotestsum \
             --format "$FORMAT" \
             --junitfile "$REPORTS_PATH/$NAME.xml" \
             --jsonfile "$REPORTS_PATH/$NAME.json" \
             --packages="$PACKAGES" \
-            -- ${{ fromJson(steps.group.outputs.metadata).go_test_flags || '' }}
+            -- -timeout "$TIMEOUT" ${{ fromJson(steps.group.outputs.metadata).go_test_flags || '' }}
       - name: Modify junit.xml for BuildPulse
         env:
           NAME: ${{ matrix.name }}
           REPORTS_PATH: ${{ steps.reports.outputs.path }}
           PACKAGES: ${{ join(fromJson(steps.group.outputs.metadata).packages, ' ') }}
-        if: always()
+        if: (!cancelled())
         run: |
           # Modify test suite name and classname attributes in JUnit XML for better grouping
           # in BuildPulse. itests are run with go test ./itests/file_test.go and therefore Go
@@ -209,7 +211,7 @@ jobs:
             sed -i 's# name="github.com/filecoin-project/lotus/\(.*\)"# name="'${{ matrix.name }}':\1"#g' "$REPORTS_PATH/$NAME.xml"
           fi
           cat "$REPORTS_PATH/$NAME.xml"
-      - if: success() || failure()
+      - if: (!cancelled())
         uses: actions/upload-artifact@v4
         with:
           name: ${{ matrix.name }}-${{ runner.os }}-${{ runner.arch }}

.github/workflows/test.yml

@@ -17,4 +17,5 @@ permissions:
 
 jobs:
   test:
+    name: Test
     uses: ./.github/workflows/reusable-test.yml

.github/workflows/very-expensive-test.yml

@@ -14,12 +14,14 @@ permissions:
 
 jobs:
   test:
+    name: Test
     if: github.event.label.name == 'need/very-expensive-tests'
     uses: ./.github/workflows/reusable-test.yml
     with:
       run_very_expensive_tests: true
   label:
-    if: always() && github.event.label.name == 'need/very-expensive-tests'
+    name: Label
+    if: github.event.label.name == 'need/very-expensive-tests'
     needs: test
     runs-on: ubuntu-latest
     steps:
@@ -35,7 +37,8 @@ jobs:
               name: context.event.label.name
             })
   issue:
-    if: always() && github.event_name == 'schedule' && needs.test.result != 'success'
+    name: Issue
+    if: failure() && github.event_name == 'schedule'
     needs: test
     runs-on: ubuntu-latest
     steps:

cmd/ci/main.go

@@ -244,7 +244,7 @@ func getRunners(testGroupName string) []Runner {
 
 func getHasVeryExpensiveTests(testGroupName string) bool {
 	testGroupNames := []string{
-		"niporep-manual",
+		"itest-niporep_manual",
 	}
 	return contains(testGroupNames, testGroupName)
 }