Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Cleanup should wait for all portions of a file sealed by all SPs #228

Open
xinaxu opened this issue Nov 16, 2023 · 0 comments
Open

Cleanup should wait for all portions of a file sealed by all SPs #228

xinaxu opened this issue Nov 16, 2023 · 0 comments
Assignees
@gammazero @xinaxu
Labels
bug Something isn't working P0

Comments

@xinaxu
Copy link
Collaborator

xinaxu commented Nov 16, 2023 •
edited
Loading

https://github.com/filecoin-project/motion/blob/421fde20ffd47e684a117567629829f8d5fd4747/integration/singularity/store.go#L564C13-L564C13

Using GetFileDealsParams which returns a list of DealState is flawed. It needs to return a list of DealState for each FileRange

Singularity needs to offer a different API to return list of DealState for each FileRange
@xinaxu xinaxu added bug Something isn't working P0 labels Nov 16, 2023
@xinaxu xinaxu moved this from Todo to In Progress in Motion Team Nov 16, 2023
@xinaxu xinaxu mentioned this issue Nov 17, 2023
Merged
xinaxu added a commit to data-preservation-programs/singularity that referenced this issue Nov 17, 2023
@xinaxu
GetFileDeals should return deals for each file range (#423)
41836a3 
First step to address
filecoin-project/motion#228
This changes GetFileDealsHandler to return list of deals for each
FileRange.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gammazero gammazero

@xinaxu xinaxu

Labels
bug Something isn't working P0
Projects
Motion Team
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gammazero @xinaxu