feat: shared: remove a bunch of code

- `BLOCK_GAS_LIMIT`: Neither the FVM nor the builtin actors care about
  the block gas limit. And if they did, it would have to be a runtime
  parameter passed from the client.
- `EPOCH_DURATION_SECONDS`: Different networks may have different block
  times, this constant is useless.
- `math`, `reward`, `smooth`: part of the reward actor calculations,
  not relevant to the FVM itself (moved to the builtin actors).
- `TOTAL_FILECOIN`, `TOTAL_FILECOIN_BASE`: Network parameter, not a
  concern of the FVM.
- `BLOCKS_PER_EPOCH`: protocol parameter, moved to the builtin actors.
- `MAX_SECTOR_NUMBER`: moved to the builtin actors.
- `Spacetime`, `SectorQuality`: moved to the builtin actors.
- `ZERO_ADDRESS`,
  `*_LOOKBACK`,
  `ALLOWABLE_CLOCK_DRIFT`,
  `NetworkParams`,
  `DefaultNetworkParams`: unused.

Author: Stebalien

Cargo.lock

@@ -192,7 +192,9 @@ impl NetworkConfig {
             epoch,
             timestamp,
             initial_state_root: initial_state,
-            circ_supply: fvm_shared::TOTAL_FILECOIN.clone(),
+            // This is just the default. The previous default of "total FIL supply" was incorrect as
+            // well, so we might as well be more neutral.
+            circ_supply: TokenAmount::zero(),
             tracing: false,
         }
     }

fvm/src/machine/mod.rs

@@ -200,7 +200,7 @@ pub struct TestData {
     pub charge_gas_calls: usize,
 }
 
-const BLOCK_GAS_LIMIT: Gas = Gas::new(fvm_shared::BLOCK_GAS_LIMIT);
+const BLOCK_GAS_LIMIT: Gas = Gas::new(10_000_000_000);
 
 impl DummyCallManager {
     pub fn new_stub() -> (Self, Rc<RefCell<TestData>>) {

fvm/tests/dummy.rs

@@ -12,7 +12,6 @@ blake2b_simd = { workspace = true }
 thiserror = { workspace = true }
 num-traits = { workspace = true }
 num-derive = { workspace = true }
-lazy_static = { workspace = true }
 cid = { workspace = true, features = ["serde-codec", "std"] }
 multihash = { workspace = true }
 unsigned-varint = { workspace = true }

shared/Cargo.toml

@@ -2,14 +2,6 @@
 // Copyright 2019-2022 ChainSafe Systems
 // SPDX-License-Identifier: Apache-2.0, MIT
 
-mod quantize;
-pub use quantize::*;
-
-const _ISO_FORMAT: &str = "%FT%X.%.9F";
-
-/// Duration of each tipset epoch.
-pub const EPOCH_DURATION_SECONDS: i64 = 30;
-
 /// Epoch number of a chain. This acts as a proxy for time within the VM.
 pub type ChainEpoch = i64;
 

shared/src/clock/mod.rs

@@ -372,7 +372,7 @@ mod test {
     use num_bigint::BigInt;
     use num_traits::Zero;
 
-    use crate::TokenAmount;
+    use super::TokenAmount;
 
     fn whole(x: impl Into<BigInt>) -> TokenAmount {
         TokenAmount::from_whole(x)

shared/src/clock/quantize.rs

@@ -4,9 +4,6 @@
 
 #![cfg_attr(coverage_nightly, feature(coverage_attribute))]
 
-#[macro_use]
-extern crate lazy_static;
-
 use address::Address;
 use cid::Cid;
 use clock::ChainEpoch;
@@ -22,37 +19,23 @@ pub mod deal;
 pub mod econ;
 pub mod error;
 pub mod event;
-pub mod math;
 pub mod message;
 pub mod piece;
 pub mod randomness;
 pub mod receipt;
-pub mod reward;
 pub mod sector;
-pub mod smooth;
 pub mod state;
 pub mod sys;
 pub mod upgrade;
 pub mod version;
 
 use crypto::hash::SupportedHashes;
-use econ::TokenAmount;
 use fvm_ipld_encoding::ipld_block::IpldBlock;
 use fvm_ipld_encoding::DAG_CBOR;
 use multihash::Multihash;
 
 use crate::error::ExitCode;
 
-lazy_static! {
-    /// Total Filecoin available to the network.
-    pub static ref TOTAL_FILECOIN: TokenAmount = TokenAmount::from_whole(TOTAL_FILECOIN_BASE);
-
-    /// Zero address used to avoid allowing it to be used for verification.
-    /// This is intentionally disallowed because it is an edge case with Filecoin's BLS
-    /// signature verification.
-    pub static ref ZERO_ADDRESS: Address = address::Network::Mainnet.parse_address("f3yaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaby2smx7a").unwrap();
-}
-
 /// Codec for raw data.
 pub const IPLD_RAW: u64 = 0x55;
 
@@ -62,51 +45,11 @@ pub const IDENTITY_HASH: u64 = 0x0;
 /// The maximum supported CID size.
 pub const MAX_CID_LEN: usize = 100;
 
-/// Identifier for Actors, includes builtin and initialized actors
-pub type ActorID = u64;
-
 /// Default bit width for the hamt in the filecoin protocol.
 pub const HAMT_BIT_WIDTH: u32 = 5;
-/// Total gas limit allowed per block. This is shared across networks.
-pub const BLOCK_GAS_LIMIT: u64 = 10_000_000_000;
-/// Total Filecoin supply.
-pub const TOTAL_FILECOIN_BASE: i64 = 2_000_000_000;
-
-// Epochs
-/// Lookback height for retrieving ticket randomness.
-pub const TICKET_RANDOMNESS_LOOKBACK: ChainEpoch = 1;
-/// Epochs to look back for verifying PoSt proofs.
-pub const WINNING_POST_SECTOR_SET_LOOKBACK: ChainEpoch = 10;
-
-/// The expected number of block producers in each epoch.
-pub const BLOCKS_PER_EPOCH: u64 = 5;
-
-/// Allowable clock drift in validations.
-pub const ALLOWABLE_CLOCK_DRIFT: u64 = 1;
-
-/// Config trait which handles different network configurations.
-pub trait NetworkParams {
-    /// Total filecoin available to network.
-    const TOTAL_FILECOIN: i64;
-
-    /// Available rewards for mining.
-    const MINING_REWARD_TOTAL: i64;
-
-    /// Initial reward actor balance. This function is only called in genesis setting up state.
-    fn initial_reward_balance() -> TokenAmount {
-        TokenAmount::from_whole(Self::MINING_REWARD_TOTAL)
-    }
-}
-
-/// Params for the network. This is now continued on into mainnet and is static across networks.
-// * This can be removed in the future if the new testnet is configred at build time
-// * but the reason to keep as is, is for an easier transition to runtime configuration.
-pub struct DefaultNetworkParams;
 
-impl NetworkParams for DefaultNetworkParams {
-    const TOTAL_FILECOIN: i64 = TOTAL_FILECOIN_BASE;
-    const MINING_REWARD_TOTAL: i64 = 1_400_000_000;
-}
+/// Identifier for Actors, includes builtin and initialized actors
+pub type ActorID = u64;
 
 /// Method number indicator for calling actor methods.
 pub type MethodNum = u64;

shared/src/econ/mod.rs

@@ -21,19 +21,9 @@ use crate::ActorID;
 /// SectorNumber is a numeric identifier for a sector. It is usually relative to a miner.
 pub type SectorNumber = u64;
 
-/// The maximum assignable sector number.
-/// Raising this would require modifying our AMT implementation.
-pub const MAX_SECTOR_NUMBER: SectorNumber = i64::MAX as u64;
-
 /// Unit of storage power (measured in bytes)
 pub type StoragePower = BigInt;
 
-/// The unit of spacetime committed to the network
-pub type Spacetime = BigInt;
-
-/// Unit of sector quality
-pub type SectorQuality = BigInt;
-
 /// SectorSize indicates one of a set of possible sizes in the network.
 #[derive(Clone, Debug, PartialEq, Eq, Copy, FromPrimitive, Serialize_repr, Deserialize_repr)]
 #[repr(u64)]