Requested changes

Author: yair100

src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs

@@ -69,14 +69,13 @@ protected async Task DecompressArchiveHereAsync(bool smart = false)
 
 				if (await FilesystemTasks.Wrap(() => StorageArchiveService.IsEncryptedAsync(archive.Path)))
 				{
-					DecompressArchiveDialog decompressArchiveDialog = new();
 					DecompressArchiveDialogViewModel decompressArchiveViewModel = new(archive)
 					{
 						IsArchiveEncrypted = true,
 						ShowPathSelection = false
 					};
 
-					decompressArchiveDialog.ViewModel = decompressArchiveViewModel;
+					DecompressArchiveDialog decompressArchiveDialog = new() { ViewModel = decompressArchiveViewModel };
 
 					if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
 						decompressArchiveDialog.XamlRoot = MainWindow.Instance.Content.XamlRoot;

src/Files.App/Actions/Content/Archives/Decompress/DecompressArchive.cs

@@ -57,15 +57,14 @@ public override async Task ExecuteAsync(object? parameter = null)
 			var password = string.Empty;
 			Encoding? encoding = null;
 
-			DecompressArchiveDialog decompressArchiveDialog = new();
 			DecompressArchiveDialogViewModel decompressArchiveViewModel = new(archive)
 			{
 				IsArchiveEncrypted = isArchiveEncrypted,
 				IsArchiveEncodingUndetermined = isArchiveEncodingUndetermined,
 				ShowPathSelection = true,
 				DetectedEncoding = detectedEncoding,
 			};
-			decompressArchiveDialog.ViewModel = decompressArchiveViewModel;
+			DecompressArchiveDialog decompressArchiveDialog = new() { ViewModel = decompressArchiveViewModel };
 
 			if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
 				decompressArchiveDialog.XamlRoot = MainWindow.Instance.Content.XamlRoot;

src/Files.App/Actions/Content/Archives/Decompress/DecompressArchiveToChildFolderAction.cs

@@ -43,13 +43,12 @@ public override async Task ExecuteAsync(object? parameter = null)
 
 				if (await FilesystemTasks.Wrap(() => StorageArchiveService.IsEncryptedAsync(archive.Path)))
 				{
-					DecompressArchiveDialog decompressArchiveDialog = new();
 					DecompressArchiveDialogViewModel decompressArchiveViewModel = new(archive)
 					{
 						IsArchiveEncrypted = true,
 						ShowPathSelection = false
 					};
-					decompressArchiveDialog.ViewModel = decompressArchiveViewModel;
+					DecompressArchiveDialog decompressArchiveDialog = new() { ViewModel = decompressArchiveViewModel };
 
 					if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
 						decompressArchiveDialog.XamlRoot = MainWindow.Instance.Content.XamlRoot;

src/Files.App/Dialogs/DecompressArchiveDialog.xaml.cs

@@ -16,7 +16,7 @@ private FrameworkElement RootAppElement
 			get => (FrameworkElement)MainWindow.Instance.Content;
 		}
 
-		public DecompressArchiveDialogViewModel ViewModel
+		public required DecompressArchiveDialogViewModel ViewModel
 		{
 			get => (DecompressArchiveDialogViewModel)DataContext;
 			set => DataContext = value;
@@ -29,7 +29,7 @@ public DecompressArchiveDialog()
 
 		private void ContentDialog_PrimaryButtonClick(ContentDialog sender, ContentDialogButtonClickEventArgs args)
 		{
-			if (ViewModel is { IsArchiveEncrypted: true })
+			if (ViewModel.IsArchiveEncrypted)
 				ViewModel.PrimaryButtonClickCommand.Execute(new DisposableArray(Encoding.UTF8.GetBytes(Password.Password)));
 		}
 

src/Files.App/Services/App/AppDialogService.cs

@@ -22,7 +22,6 @@ public DialogService()
 				{ typeof(CredentialDialogViewModel), () => new CredentialDialog() },
 				{ typeof(ElevateConfirmDialogViewModel), () => new ElevateConfirmDialog() },
 				{ typeof(FileSystemDialogViewModel), () => new FilesystemOperationDialog() },
-				{ typeof(DecompressArchiveDialogViewModel), () => new DecompressArchiveDialog() },
 				{ typeof(CreateShortcutDialogViewModel), () => new CreateShortcutDialog() },
 				{ typeof(ReorderSidebarItemsDialogViewModel), () => new ReorderSidebarItemsDialog() },
 				{ typeof(AddBranchDialogViewModel), () => new AddBranchDialog() },