Fix: Fixed crash that would sometimes occur when updating

Author: yaira2

src/Files.App/Services/App/AppUpdateSideloadService.cs

@@ -1,10 +1,10 @@
 // Copyright (c) Files Community
 // Licensed under the MIT License.
 
-using CommunityToolkit.WinUI.Helpers;
 using Microsoft.Extensions.Logging;
 using System.IO;
 using System.Net.Http;
+using System.Runtime.InteropServices;
 using System.Xml.Serialization;
 using Windows.ApplicationModel;
 using Windows.Management.Deployment;
@@ -123,34 +123,71 @@ public async Task CheckForUpdatesAsync()
 
 		public async Task CheckAndUpdateFilesLauncherAsync()
 		{
-			var destFolderPath = Path.Combine(UserDataPaths.GetDefault().LocalAppData, "Files");
-			var destExeFilePath = Path.Combine(destFolderPath, "Files.App.Launcher.exe");
-
-			if (File.Exists(destExeFilePath))
+			try
 			{
+				var destFolderPath = Path.Combine(UserDataPaths.GetDefault().LocalAppData, "Files");
+				var destExeFilePath = Path.Combine(destFolderPath, "Files.App.Launcher.exe");
+
+				if (!File.Exists(destExeFilePath))
+					return;
+
 				var hashEqual = false;
-				var srcHashFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appx:///Assets/FilesOpenDialog/Files.App.Launcher.exe.sha256"));
+				var srcHashFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appx:///Assets/FilesOpenDialog/Files.App.Launcher.exe.sha256"))
+					.AsTask().ConfigureAwait(false);
 				var destHashFilePath = Path.Combine(destFolderPath, "Files.App.Launcher.exe.sha256");
 
 				if (File.Exists(destHashFilePath))
 				{
-					await using var srcStream = (await srcHashFile.OpenReadAsync()).AsStream();
-					await using var destStream = File.OpenRead(destHashFilePath);
-
-					hashEqual = HashEqual(srcStream, destStream);
+					try
+					{
+						await using var srcStream = (await srcHashFile.OpenReadAsync().AsTask().ConfigureAwait(false)).AsStream();
+						await using var destStream = File.OpenRead(destHashFilePath);
+						hashEqual = HashEqual(srcStream, destStream);
+					}
+					catch (COMException ex)
+					{
+						Logger?.LogWarning(ex, "Failed to compare hash files");
+						return;
+					}
+					catch (IOException ex)
+					{
+						Logger?.LogWarning(ex, "IO error while reading hash files");
+						return;
+					}
 				}
 
 				if (!hashEqual)
 				{
-					var srcExeFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appx:///Assets/FilesOpenDialog/Files.App.Launcher.exe"));
-					var destFolder = await StorageFolder.GetFolderFromPathAsync(destFolderPath);
-
-					await srcExeFile.CopyAsync(destFolder, "Files.App.Launcher.exe", NameCollisionOption.ReplaceExisting);
-					await srcHashFile.CopyAsync(destFolder, "Files.App.Launcher.exe.sha256", NameCollisionOption.ReplaceExisting);
-
-					Logger?.LogInformation("Files.App.Launcher updated.");
+					try
+					{
+						var srcExeFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appx:///Assets/FilesOpenDialog/Files.App.Launcher.exe"))
+							.AsTask().ConfigureAwait(false);
+						var destFolder = await StorageFolder.GetFolderFromPathAsync(destFolderPath).AsTask().ConfigureAwait(false);
+
+						await srcExeFile.CopyAsync(destFolder, "Files.App.Launcher.exe", NameCollisionOption.ReplaceExisting)
+							.AsTask().ConfigureAwait(false);
+						await srcHashFile.CopyAsync(destFolder, "Files.App.Launcher.exe.sha256", NameCollisionOption.ReplaceExisting)
+							.AsTask().ConfigureAwait(false);
+
+						Logger?.LogInformation("Files.App.Launcher updated.");
+					}
+					catch (COMException ex)
+					{
+						Logger?.LogError(ex, ex.Message);
+						return;
+					}
+					catch (UnauthorizedAccessException ex)
+					{
+						Logger?.LogError(ex, ex.Message);
+						return;
+					}
 				}
 			}
+			catch (Exception ex)
+			{
+				Logger?.LogError(ex, ex.Message);
+				return;
+			}
 
 			bool HashEqual(Stream a, Stream b)
 			{