Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: the app won't run on the background if another branch of the app is running #14291

Closed
0x5bfa opened this issue Dec 25, 2023 · 3 comments
Closed

Comments

@0x5bfa
Copy link
Member

0x5bfa commented Dec 25, 2023

Description

As the title, the app won't run on the background if another branch version of the app is running on the foreground.

Code where the problem is caused; line 161

if (userSettingsService.GeneralSettingsService.LeaveAppRunning &&
!AppModel.ForceProcessTermination &&
!Process.GetProcessesByName("Files").Any(x => x.Id != Process.GetCurrentProcess().Id))

Could we change the process name according to the app branch name instead of just being "Files"?

Steps To Reproduce

  1. Run the app of a version; Dev, Preview, Stable
  2. Run the app of another version.
  3. Close the first one's window
  4. The first one's process should run on the background but not.

Requirements

  • Force to run

Files Version

2.0.50

Windows Version

10.0.22000.0

Log File

No particular log was output.

@0x5bfa 0x5bfa added the bug label Dec 25, 2023
@0x5bfa
Copy link
Member Author

0x5bfa commented Dec 25, 2023

I found this when I was testing the system tray icon. Because of this issue, the icon won't be displayed as well.

@hishitetsu
Copy link
Member

Could we change the process name according to the app branch name instead of just being "Files"?

I've already created an issue on this. #13112

@yaira2
Copy link
Member

yaira2 commented Dec 25, 2023

For this reason, the option is turned off by default on the dev branch. Either way, let's merge with #13112

@yaira2 yaira2 closed this as completed Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants