Code Quality: Replaced DllImport calls with CsWin32 generations for event object operations #17086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lamparter can you please fill out the template with the steps used to validate these changes? |
|
@0x5bfa requesting your review |
0x5bfa
suggested changes
May 1, 2025
| }); | ||
|
|
||
| _ = CoWaitForMultipleObjects( | ||
| _ = Win32PInvoke.CoWaitForMultipleObjects( |
There was a problem hiding this comment.
Pretty sure you should pin the array.
0x5bfa
suggested changes
May 3, 2025
| { | ||
| fixed (char* fileDialog = "FILEDIALOG") | ||
| { | ||
| HANDLE eventHandle = PInvoke.CreateEvent(bManualReset: false, bInitialState: false, lpName: fileDialog); |
There was a problem hiding this comment.
Can't you just:
Suggested change
| HANDLE eventHandle = PInvoke.CreateEvent(bManualReset: false, bInitialState: false, lpName: fileDialog); | |
| HANDLE eventHandle = PInvoke.CreateEvent((SECURITY_ATTRIBUTES*)null, false, false, fileDialog); |
| Win32PInvoke.CloseHandle(eventHandle); | ||
| unsafe | ||
| { | ||
| fixed (char* fileDialog = "FILEDIALOG") |
| { | ||
| fixed (char* fileDialog = "FILEDIALOG") | ||
| { | ||
| HANDLE eventHandle = PInvoke.CreateEvent(bManualReset: false, bInitialState: false, lpName: fileDialog); |
| { | ||
| IntPtr eventHandle = CreateEvent(IntPtr.Zero, true, false, null); | ||
| HANDLE eventHandle = PInvoke.CreateEvent(bManualReset: true, bInitialState: false, lpName: null); |
| { | ||
| IntPtr eventHandle = CreateEvent(IntPtr.Zero, true, false, null); | ||
| HANDLE eventHandle = PInvoke.CreateEvent(bManualReset: true, bInitialState: false, lpName: null); |
| @@ -2124,7 +2125,7 @@ private void WatchForDirectoryChanges(string path, CloudDriveSyncStatus syncStat | |||
| notifyFilters |= FILE_NOTIFY_CHANGE_ATTRIBUTES; | |||
|
|
|||
| var overlapped = new OVERLAPPED(); | |||
| overlapped.hEvent = CreateEvent(IntPtr.Zero, false, false, null); | |||
| overlapped.hEvent = PInvoke.CreateEvent(null, false, false, null).DangerousGetHandle(); | |||
| @@ -2235,7 +2236,7 @@ private void WatchForGitChanges() | |||
| var notifyFilters = FILE_NOTIFY_CHANGE_DIR_NAME | FILE_NOTIFY_CHANGE_FILE_NAME | FILE_NOTIFY_CHANGE_LAST_WRITE | FILE_NOTIFY_CHANGE_SIZE | FILE_NOTIFY_CHANGE_CREATION; | |||
|
|
|||
| var overlapped = new OVERLAPPED(); | |||
| overlapped.hEvent = CreateEvent(IntPtr.Zero, false, false, null); | |||
| overlapped.hEvent = PInvoke.CreateEvent(null, false, false, null).DangerousGetHandle(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues