Merge pull request #6 from mtsokol/test-propagate-map-queries

TEST: Test `propagate_map_queries` pass

Author: mtsokol

pyproject.toml

@@ -7,7 +7,7 @@ readme = "README.md"
 packages = [{include = "finch", from = "src"}]
 
 [tool.poetry.dependencies]
-python = "^3.10"
+python = "^3.11"
 numpy = ">=1.19"
 
 [tool.poetry.group.test.dependencies]

src/finch/autoschedule/__init__.py

@@ -1,4 +1,4 @@
-from .finch_logic import (
+from ..finch_logic import (
     Aggregate,
     Alias,
     Deferred,
@@ -15,7 +15,7 @@
     Table,
 )
 from .optimize import optimize, propagate_map_queries
-from .rewrite_tools import PostOrderDFS, PostWalk, PreWalk
+from ..symbolic import PostOrderDFS, PostWalk, PreWalk
 
 __all__ = [
     "Aggregate",

src/finch/autoschedule/compiler.py

@@ -2,7 +2,7 @@
 from textwrap import dedent
 from typing import Any
 
-from .finch_logic import (
+from ..finch_logic import (
     Alias,
     Deferred,
     Field,

src/finch/autoschedule/executor.py

@@ -1,5 +1,5 @@
 from .compiler import LogicCompiler
-from .rewrite_tools import gensym
+from ..symbolic import gensym
 
 
 class LogicExecutor:

src/finch/autoschedule/optimize.py

@@ -1,6 +1,6 @@
 from .compiler import LogicCompiler
-from .finch_logic import Aggregate, Alias, LogicNode, MapJoin, Plan, Produces, Query
-from .rewrite_tools import Chain, PostOrderDFS, PostWalk, PreWalk, Rewrite
+from ..finch_logic import Aggregate, Alias, LogicNode, MapJoin, Plan, Produces, Query
+from ..symbolic import Chain, PostOrderDFS, PostWalk, PreWalk, Rewrite
 
 
 def optimize(prgm: LogicNode) -> LogicNode:
@@ -52,4 +52,4 @@ def __init__(self, ctx: LogicCompiler):
 
     def __call__(self, prgm: LogicNode):
         prgm = optimize(prgm)
-        return self.ctx(prgm)
+        return self.ctx(prgm)

src/finch/finch_logic/nodes.py

@@ -191,6 +191,10 @@ def children(self):
         """Returns the children of the node."""
         return [self.op, *self.args]
 
+    @classmethod
+    def make_term(cls, head, op, *args):
+        return head(op, args)
+
 
 @dataclass(eq=True, frozen=True)
 class Aggregate(LogicNode):
@@ -412,3 +416,7 @@ def is_stateful():
     def children(self):
         """Returns the children of the node."""
         return [*self.bodies]
+
+    @classmethod
+    def make_term(cls, head, *val):
+        return head(val)

src/finch/symbolic/rewriters.py

@@ -87,7 +87,7 @@ def __call__(self, x: Term) -> Term | None:
             new_args = list(map(self, args))
             if all(arg is None for arg in new_args):
                 return self.rw(x)
-            y = x.make_term(*map(lambda x1, x2: default_rewrite(x1, x2), new_args, args))
+            y = x.make_term(x.head(), *map(lambda x1, x2: default_rewrite(x1, x2), new_args, args))
             return default_rewrite(self.rw(y), y)
         return self.rw(x)
 

src/finch/symbolic/term.py

@@ -30,7 +30,10 @@ def is_expr(self) -> bool:
 
     @abstractmethod
     def make_term(self, head: Any, children: List[Term]) -> Term:
-        """Construct a new term in the same family of terms with the given head type and children."""
+        """
+            Construct a new term in the same family of terms with the given head type and children.
+            This function should satisfy `x == x.make_term(x.head(), *x.children())`
+        """
         pass
 
     def __hash__(self) -> int:
@@ -52,4 +55,4 @@ def PreOrderDFS(node: Term) -> Iterator[Term]:
     yield node
     if node.is_expr():
         for arg in node.children():
-            yield from PreOrderDFS(arg)
+            yield from PreOrderDFS(arg)

tests/test_scheduler.py

@@ -0,0 +1,21 @@
+from finch.autoschedule import propagate_map_queries
+from finch.finch_logic import *
+
+
+def test_propagate_map_queries_simple():
+    plan = Plan(
+        (
+            Query(Alias("A10"), Aggregate(Immediate("+"), Immediate(0), Immediate("[1,2,3]"), ())),
+            Query(Alias("A11"), Alias("A10")),
+            Produces((Alias("11"),)),
+        )
+    )
+    expected = Plan(
+        (
+            Query(Alias("A11"), MapJoin(Immediate("+"), (Immediate(0), Immediate("[1,2,3]")))),
+            Produces((Alias("11"),)),
+        )
+    )
+
+    result = propagate_map_queries(plan)
+    assert result == expected