Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Suggestions for Smart Suggest/Autocomplete requests #19

Open
TheKeymaster opened this issue Dec 13, 2018 · 1 comment
Open

Restructure Suggestions for Smart Suggest/Autocomplete requests #19

TheKeymaster opened this issue Dec 13, 2018 · 1 comment
Assignees
@TheKeymaster
Labels
Priority: normal Normal priority.

Comments

@TheKeymaster
Copy link
Contributor

Relevant is

  • Request parameters
  • Response objects/additional properties
  • (Validating the Response against some Json schema)*

*Maybe it is also useful to validate the Json from FINDOLOGIC again, but I am unsure if it makes sense or not, since FINDOLOGIC should always respond with correctly validated data. Also if the search response will be updated, a response might cause an exception since it is no longer schema conform.
@TheKeymaster TheKeymaster self-assigned this Dec 13, 2018
@TheKeymaster TheKeymaster added future version Will be fixed in a future version. Priority: normal Normal priority. labels Dec 13, 2018
@TheKeymaster TheKeymaster mentioned this issue Dec 27, 2018
Closed
@TheKeymaster TheKeymaster added this to the rc-1.0.0 milestone Jan 7, 2019
@TheKeymaster TheKeymaster removed the future version Will be fixed in a future version. label Jan 21, 2019
@TheKeymaster
Copy link
Contributor Author

Actually we should introduce multiple suggestions. Not only a „Suggestion“, but a „PromotionSuggestion“ or „ProductSuggestion“, etc.

@TheKeymaster TheKeymaster removed this from the v1.0.0-rc.1 milestone Oct 18, 2019
@TheKeymaster TheKeymaster changed the title Support more things for JsonResponse Restructure Suggestions for Smart Suggest/Autocomplete requests Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheKeymaster TheKeymaster

Labels
Priority: normal Normal priority.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheKeymaster